Rockbox

Tasklist

FS#12188 - Fix perl scripts that used Switch.

Attached to Project: Rockbox
Opened by Sean Bartell (wtachi) - Monday, 11 July 2011, 07:19 GMT
Last edited by Thomas Jarosch (thomasjfox) - Tuesday, 16 August 2011, 19:30 GMT
Task Type Patches
Category Build environment
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

The recent Perl 5.14.0 release removed the Switch module. This patch replaces it with given/when (introduced more than three years ago).
This task depends upon

Closed by  Thomas Jarosch (thomasjfox)
Tuesday, 16 August 2011, 19:30 GMT
Reason for closing:  Accepted
Additional comments about closing:  Accepted as r30323.

Thanks Nick! (also see r30324 ;))
Comment by Nick Peskett (nickp) - Tuesday, 19 July 2011, 04:59 GMT
Why not just use if/ elsif/ else? This would be compatible with all perl versions.
Comment by Thomas Jarosch (thomasjfox) - Saturday, 13 August 2011, 17:16 GMT
Hmm, this change broke the Nokia N900/maemo 5 build: It's stuck at perl 5.8.4.

What about the proposed change from Nick?
Comment by Nick Peskett (nickp) - Saturday, 13 August 2011, 22:36 GMT
Here's a patch using if/ elsif/ else.
Comment by Dominik Riebeling (bluebrother) - Sunday, 14 August 2011, 19:10 GMT
It might make sense to add a comment that tells why neither switch nor given/when is used. Apart from that I don't see a reason against using if/elsif/else.

Loading...