Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#12218 - embedded album art for ASF

Attached to Project: Rockbox
Opened by Andree Buschmann (Buschel) - Saturday, 06 August 2011, 15:20 GMT+2
Last edited by Andree Buschmann (Buschel) - Sunday, 07 August 2011, 17:27 GMT+2
Task Type Patches
Category ID3 / meta data
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.8.1
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

The attached patch adds embedded album art for ASF. I am not 100% glad with the implementation as there ares till some magic numbers left. Also I cannot really test this on a large number of files with embedded jpg's yet.
I would be glad to have some testers for this patch.
   asf_AA_v01.patch (2 KiB) 
 apps/metadata/asf.c |   30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

This task depends upon

Closed by  Andree Buschmann (Buschel)
Sunday, 07 August 2011, 17:27 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Submitted wit r30263.
Comment by Andree Buschmann (Buschel) - Sunday, 07 August 2011, 00:20 GMT+2
This new version is more error resilient and avoids to use magic numbers especially for seeks. It also covers distinction between png and jpg (even though embedded png is generally not supported yet).
Last issue is that this will only work for embedded images smaller than 64 KB. Above this limit the ASF-tag is changing a lot and the detection of embedded images does not work.

Edit: Also updated the manual.
   asf_AA_v04.patch (4.3 KiB) 
 apps/metadata/asf.c              |   47 +++++++++++++++++++++++++++++++++++++++
 manual/appendix/file_formats.tex |    4 ++-
 2 files changed, 50 insertions(+), 1 deletion(-)

Loading...