Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#12231 - Centralize codec compilation flag setting

Attached to Project: Rockbox
Opened by Nils Wallménius (nls) - Sunday, 14 August 2011, 18:44 GMT+2
Last edited by Nils Wallménius (nls) - Thursday, 18 August 2011, 18:34 GMT+2
Task Type Patches
Category Build environment
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.9
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch centralizes the selection of codec compilation flags to codec.make to avoid having to duplicate the per cpu selection logic and the build rule in the codec lib make files and make tweaking easier.

The two special cases, libamd and libspeex were left alone.

I plan to introduce a var for arm generation so that appropriate flags can be selected per generation as benchmarking results have shown that different arm arches might have different optimal flags.
   codec_flags.diff (19.6 KiB) 
 apps/codecs/libfaad/libfaad.make             |    8 ---
 apps/codecs/libgme/libhes.make               |   11 -----
 apps/codecs/libgme/libvgm.make               |   11 -----
 apps/codecs/libgme/libsgc.make               |   11 -----
 apps/codecs/libgme/libnsf.make               |   11 -----
 apps/codecs/libgme/libkss.make               |   11 -----
 apps/codecs/libgme/libgbs.make               |   11 -----
 apps/codecs/libgme/libay.make                |   11 -----
 apps/codecs/libpcm/libpcm.make               |    7 ---
 apps/codecs/libwma/libwma.make               |   13 ------
 apps/codecs/liba52/liba52.make               |   13 ------
 apps/codecs/libwmapro/libwmapro.make         |   12 -----
 apps/codecs/libtremor/libtremor.make         |   13 ------
 apps/codecs/librm/librm.make                 |    7 ---
 apps/codecs/libm4a/libm4a.make               |    7 ---
 apps/codecs/demac/libdemac.make              |   12 -----
 apps/codecs/libasap/libasap.make             |    7 ---
 apps/codecs/libtta/libtta.make               |   11 -----
 apps/codecs/libffmpegFLAC/libffmpegFLAC.make |    8 ---
 apps/codecs/libcook/libcook.make             |   13 ------
 apps/codecs/libmusepack/libmusepack.make     |    8 ---
 apps/codecs/libasf/libasf.make               |   14 ------
 apps/codecs/codecs.make                      |   58 +++++++++++++++++++++++++++
 apps/codecs/libatrac/libatrac.make           |   13 ------
 apps/codecs/libwavpack/libwavpack.make       |   13 ------
 apps/codecs/libalac/libalac.make             |   12 -----
 apps/codecs/libspc/libspc.make               |    7 ---
 27 files changed, 58 insertions(+), 275 deletions(-)

This task depends upon

Closed by  Nils Wallménius (nls)
Thursday, 18 August 2011, 18:34 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  committed
Comment by MichaelGiacomelli (saratoga) - Sunday, 14 August 2011, 22:43 GMT+2
Stupid question, but is it ok to do this:

$(A52LIB) : CODECFLAGS += -O1

...

$(A52LIB) : CODECFLAGS += -O2

I guess the last optimization flag is the one that sticks?
Comment by Nils Wallménius (nls) - Tuesday, 16 August 2011, 16:31 GMT+2
Yes that is correct (CODECFLAGS already includes CFLAGS which contains the core -O switch too).

edit: from the gcc manual "If you use multiple -O options, with or without level numbers, the last such option is the one that is effective."

Loading...