Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#12246 - Progress bar cuesheet markers wrap with long audio files.

Attached to Project: Rockbox
Opened by Nick Peskett (nickp) - Friday, 26 August 2011, 05:54 GMT+2
Last edited by Andree Buschmann (Buschel) - Friday, 26 August 2011, 17:52 GMT+2
Task Type Bugs
Category Music playback
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.9
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

When playing a file longer than around 6 hours with cuesheet support enabled, cues > around 6 hours cause long unsigned multiplication overflows, making the marker x offset wrap back to the start of the progress bar.

To reproduce:

Enable Settings > Playback Settings > Cuesheet Support.
Generate mp3 & cue using attached perl script.
There ought to be 10 evenly spaced cues, but they start wrapping after the sixth.

Solution (attached):

Cast the cue offset as a long long when performing the multiplication.
   make_test_files.pl (1 KiB)
   cuesheet_fix.patch (0.4 KiB) 
 apps/cuesheet.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

This task depends upon

Closed by  Andree Buschmann (Buschel)
Friday, 26 August 2011, 17:52 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Submitted with r30359.

Loading...