Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#12257 - Goban mixes up stone colors on inverse displays

Attached to Project: Rockbox
Opened by Michael Goerner (v4hn) - Saturday, 03 September 2011, 15:06 GMT+2
Last edited by Nils Wallménius (nls) - Thursday, 08 September 2011, 14:44 GMT+2
Task Type Patches
Category Games
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.9
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

As the summary states the goban code doesn't consider,
whether the foreground color of the display is bright or dark.
This results in black playing first with white stones on some sansa players.

The attached patch distingishs between SANSA_CLIP/SANSA_CLIPV2/SANSA_CLIPPLUS
and everything else, as those are the only players with bright foreground I found.

Tested with a couple of different simulators and on Clip+.
   rockbox-fix_sansa_goban_colors.diff (1.5 KiB) 
 apps/plugins/goban/display.c |   29 ++++++++++++-----------------
 1 file changed, 12 insertions(+), 17 deletions(-)

This task depends upon

Closed by  Nils Wallménius (nls)
Thursday, 08 September 2011, 14:44 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  committed, thanks
Comment by Nils Wallménius (nls) - Sunday, 04 September 2011, 13:52 GMT+2
we have a #define for such displays, HAVE_NEGATIVE_LCD it's better to test for that as it covers one more such target, the mrobe 100
Comment by Michael Goerner (v4hn) - Sunday, 04 September 2011, 14:48 GMT+2
Thanks, I looked for such a constant, but didn't find it..
The updated patch it attached.
   rockbox-fix_negative_lcd_goban_colors.diff (1.4 KiB) 
 apps/plugins/goban/display.c |   29 ++++++++++++-----------------
 1 file changed, 12 insertions(+), 17 deletions(-)

Loading...