Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#12258 - Do not use -ffunction-sections -fdata-sections for mingw builds

Attached to Project: Rockbox
Opened by Andree Buschmann (Buschel) - Saturday, 03 September 2011, 15:32 GMT+2
Last edited by Andree Buschmann (Buschel) - Wednesday, 07 September 2011, 21:25 GMT+2
Task Type Patches
Category Build environment
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.9
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

The attached patch changes the makefiles for plugins, codeclibs and codecs/lib/tlsf to not use '-ffunction-sections' and '-fdata-sections' for simulator builds. This removes several warnings when compiling in my environment (Ubuntu + mingw32).

This needs a review, I am not sure whether I am detecting simulator builds 100% right via "ifdef APP_TYPE".
   make_v01.patch (2.5 KiB) 
 apps/plugins/plugins.make         |    9 ++++++++-
 apps/codecs/lib/libcodec.make     |    7 ++++++-
 apps/codecs/lib/tlsf/libtlsf.make |    7 ++++++-
 3 files changed, 20 insertions(+), 3 deletions(-)

This task depends upon

Closed by  Andree Buschmann (Buschel)
Wednesday, 07 September 2011, 21:25 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Submitted with r30468.
Comment by Andree Buschmann (Buschel) - Sunday, 04 September 2011, 10:30 GMT+2
The new version checks whether a mingw cross compiler is used. In this case '-ffunction-sections' and '-fdata-sections' is not used.
   make_v02.patch (2.6 KiB) 
 apps/plugins/plugins.make         |    9 ++++++++-
 apps/codecs/lib/libcodec.make     |    7 ++++++-
 apps/codecs/lib/tlsf/libtlsf.make |    7 ++++++-
 3 files changed, 20 insertions(+), 3 deletions(-)

Comment by Andree Buschmann (Buschel) - Wednesday, 07 September 2011, 20:35 GMT+2
'-ffunction-sections' and '-fdata-sections' should be not used for cygwin as well. Therefor check for "sdl-sim".
   make_v03.patch (2.6 KiB) 
 apps/plugins/plugins.make         |    9 ++++++++-
 apps/codecs/lib/libcodec.make     |    7 ++++++-
 apps/codecs/lib/tlsf/libtlsf.make |    7 ++++++-
 3 files changed, 20 insertions(+), 3 deletions(-)

Loading...