Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#12259 - Removed bug and compiler warnings from mikmod

Attached to Project: Rockbox
Opened by Andree Buschmann (Buschel) - Saturday, 03 September 2011, 22:36 GMT+2
Last edited by Andree Buschmann (Buschel) - Sunday, 04 September 2011, 01:58 GMT+2
Task Type Patches
Category Plugins
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.9
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

mokmod is configured to be build with '-w". Therefor lots of compiler warnings are suppressed. This patch disables '-w' and resolves all compiler warnings. At least 1 bug has been resolved through this as well: in load_gt2.c loadChunk() an out of bounds access was found, casued by writing to the wrong address.

Edit: I have attached two files (1x XM, 1x IT) for test purposes. Both play fine on my simulator.
   mikmod_v01.patch (32.5 KiB) 
 apps/plugins/mikmod/virtch.c           |    2 
 apps/plugins/mikmod/load_s3m.c         |    6 -
 apps/plugins/mikmod/load_m15.c         |    7 -
 apps/plugins/mikmod/mmio.c             |   12 +-
 apps/plugins/mikmod/mlutil.c           |    2 
 apps/plugins/mikmod/load_gdm.c         |    1 
 apps/plugins/mikmod/virtch_common.c    |    2 
 apps/plugins/mikmod/mplayer.c          |  164 +++++++++++++++++++++++++++++++--
 apps/plugins/mikmod/mikmod.make        |    2 
 apps/plugins/mikmod/load_xm.c          |    5 -
 apps/plugins/mikmod/load_uni.c         |    3 
 apps/plugins/mikmod/load_gt2.c         |    3 
 apps/plugins/mikmod/load_mtm.c         |    3 
 apps/plugins/mikmod/load_amf.c         |    6 -
 apps/plugins/mikmod/load_stm.c         |    4 
 apps/plugins/mikmod/load_ult.c         |    1 
 apps/plugins/mikmod/mikmod_internals.h |    2 
 apps/plugins/mikmod/load_far.c         |    1 
 apps/plugins/mikmod/load_imf.c         |   15 +--
 apps/plugins/mikmod/load_it.c          |   14 +-
 apps/plugins/mikmod/load_mod.c         |    3 
 apps/plugins/mikmod/mikmod.c           |   22 ++--
 apps/plugins/mikmod/load_dsm.c         |    1 
 apps/plugins/mikmod/load_669.c         |    1 
 apps/plugins/mikmod/mmalloc.c          |    4 
 apps/plugins/mikmod/load_asy.c         |    8 +
 apps/plugins/mikmod/load_okt.c         |    3 
 27 files changed, 239 insertions(+), 58 deletions(-)

   Temp.7z (448.7 KiB)
This task depends upon

Closed by  Andree Buschmann (Buschel)
Sunday, 04 September 2011, 01:58 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Submitted with r30424 + fixes in r30425/r30426.

Loading...