Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Plugins
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.9
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Buschel - 2011-09-03
Last edited by Buschel - 2011-09-03

FS#12259 - Removed bug and compiler warnings from mikmod

mokmod is configured to be build with ‘-w”. Therefor lots of compiler warnings are suppressed. This patch disables ‘-w’ and resolves all compiler warnings. At least 1 bug has been resolved through this as well: in load_gt2.c loadChunk() an out of bounds access was found, casued by writing to the wrong address.

Edit: I have attached two files (1x XM, 1x IT) for test purposes. Both play fine on my simulator.

   mikmod_v01.patch (32.5 KiB)
   Temp.7z (448.7 KiB)
Closed by  Buschel
2011-09-03 23:58
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Submitted with r30424 + fixes in r30425/r30426.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing