Rockbox

Tasklist

FS#12259 - Removed bug and compiler warnings from mikmod

Attached to Project: Rockbox
Opened by Andree Buschmann (Buschel) - Saturday, 03 September 2011, 20:36 GMT
Last edited by Andree Buschmann (Buschel) - Saturday, 03 September 2011, 23:58 GMT
Task Type Patches
Category Plugins
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Release 3.9
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

mokmod is configured to be build with '-w". Therefor lots of compiler warnings are suppressed. This patch disables '-w' and resolves all compiler warnings. At least 1 bug has been resolved through this as well: in load_gt2.c loadChunk() an out of bounds access was found, casued by writing to the wrong address.

Edit: I have attached two files (1x XM, 1x IT) for test purposes. Both play fine on my simulator.
This task depends upon

Closed by  Andree Buschmann (Buschel)
Saturday, 03 September 2011, 23:58 GMT
Reason for closing:  Accepted
Additional comments about closing:  Submitted with r30424 + fixes in r30425/r30426.

Loading...