Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#12261 - -fgnu89-inline breaks Cygwin build

Attached to Project: Rockbox
Opened by Steve Bavin (pondlife) - Tuesday, 06 September 2011, 18:35 GMT+2
Last edited by Andree Buschmann (Buschel) - Wednesday, 07 September 2011, 20:37 GMT+2
Task Type Bugs
Category Build environment
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

r30420 added -fgnu89-inline to the doom and mpegplayer makefiles, this isn't supported on Cygwin (gcc 3.4.4).

I'm not big on makefiles, so am not sure what a suitable test would be - i.e. how to detect gcc 3.x.
This task depends upon

Closed by  Andree Buschmann (Buschel)
Wednesday, 07 September 2011, 20:37 GMT+2
Reason for closing:  Fixed
Additional comments about closing:  Submitted with r30467.
Comment by Andree Buschmann (Buschel) - Tuesday, 06 September 2011, 23:50 GMT+2
I reworked this a bit. "-fgnu89-inline" was introduced with GCC 4.1.3 (=GCCNUM 401). The attached only sets "-fgnu89-inline" if GCCNUM >= 401 is true. This compiles now for cygwin simulator (GCC 3.0.4), cygwin target (4.4.4), my Ubuntu mingw32 simulator (GCC 4.2.1) and Ubuntu target (GCC 4.4.4) w/o the "gnu89 inline" warnings.
   make_GCCNUM_v01.patch (1.1 KiB) 
 apps/plugins/mpegplayer/mpegplayer.make |    4 ++--
 apps/plugins/doom/doom.make             |    4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

Comment by Steve Bavin (pondlife) - Wednesday, 07 September 2011, 09:02 GMT+2
Yup, fixit if for me - thanks.
Comment by Steve Bavin (pondlife) - Wednesday, 07 September 2011, 09:41 GMT+2
Oops, mobile keyboard wrongness, hope you understood!

Loading...