Rockbox

Tasklist

FS#12269 - Add "USB Hide Internal Drive" to english-us.lang

Attached to Project: Rockbox
Opened by Richard Brittain (rbbrittain) - Saturday, 10 September 2011, 13:52 GMT
Last edited by Frank Gevaerts (fg) - Tuesday, 13 September 2011, 19:21 GMT
Task Type Patches
Category Language
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

I've been using Rockbox for years on my Sansa e380 (v1), but I'm a noob at modern-day code-writing. (To show you how old my skills are, my last formal training was in college--in languages like Cobol, Fortran & IBM assembler. ;) ) I just installed the Ubuntu VirtualBox image as my development environment within the last week and managed to compile a couple of SVN updates.

Nonetheless, I have a very simple patch for a first-timer that should be easy to commit: Add the "USB Hide Internal Drive" phrase to english-us.lang. Since english-us is just a minor patch job on english.lang (replace "colour" with "color", etc.) and had no issues before that phrase was added, and the new phrase is just fine in American English, this should be a no-brainer for anyone who can commit it.

To be safe, I did use genlang to create it from the current SVN files, even though it's really a simple cut-and-paste job; all I had to do to new-english-us.lang after that was remove the comments genlang inserted with the new phrase.

Thanks in advance!
This task depends upon

Closed by  Frank Gevaerts (fg)
Tuesday, 13 September 2011, 19:21 GMT
Reason for closing:  Accepted
Additional comments about closing:  Thanks, committed as r30517

As a note for future contributions, patches are easier to work with than the entire file.
Comment by Richard Brittain (rbbrittain) - Saturday, 10 September 2011, 14:28 GMT
Just built & installed r30494 with this patch on my e280; everything seems OK. New command shows up under Settings > General Settings > System. Should be OK to commit.

Loading...