Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#12303 - iPod Video USB broken since r30546

Attached to Project: Rockbox
Opened by Andree Buschmann (Buschel) - Friday, 30 September 2011, 22:02 GMT+2
Last edited by Andree Buschmann (Buschel) - Monday, 03 October 2011, 08:15 GMT+2
Task Type Bugs
Category Operating System/Drivers
Status Closed
Assigned To No-one
Player Type iPod 5G
Severity High
Priority Normal
Reported Version Release 3.9
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Since r30546 my iPod Video does not connect via USB when running rockbox. The emergency diskmode works fine, r30545 works as well.
This task depends upon

Closed by  Andree Buschmann (Buschel)
Monday, 03 October 2011, 08:15 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  r30701
Comment by Andree Buschmann (Buschel) - Friday, 30 September 2011, 22:32 GMT+2
Rolling back r30546 and r30549 against current svn (r30622) solves the problem.
Comment by Michael Sevakis (MikeS) - Saturday, 01 October 2011, 09:37 GMT+2
I tried all my PortalPlayer 502x targets. sa9200 wouldn't boot so I couldn't check but other than that the other three would connect just fine.

So, I wonder what's up there with video.
Comment by Andree Buschmann (Buschel) - Saturday, 01 October 2011, 09:44 GMT+2
Can I give any more details which might help to understand the cause?

Some detail I did not mention so far: If I connect USB rockbox switches to the USB-screen. So, rockbox recognizes the USB-connect. But there is no USB-connection established, there is no new drive available under windows.
Comment by Michael Sevakis (MikeS) - Saturday, 01 October 2011, 09:52 GMT+2
Does this do anything to fix the issue?

Edit: reading your comment that showed up while making the patch, I'm guessing "no".
   remove-cable-status-check.patch (0.5 KiB) 
 firmware/target/arm/usb-fw-pp502x.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comment by Michael Sevakis (MikeS) - Saturday, 01 October 2011, 10:05 GMT+2
Hmmm...details. Is it just the computer/OS or something? I feel like there's some silly oversight.
Comment by Andree Buschmann (Buschel) - Saturday, 01 October 2011, 10:05 GMT+2
Your patch doesn't fix it.

Some more details: OS is Windows7.
Comment by Michael Sevakis (MikeS) - Saturday, 01 October 2011, 10:07 GMT+2
Oh, and is it just the iPod Video or any other iPod too?
Comment by Andree Buschmann (Buschel) - Saturday, 01 October 2011, 10:11 GMT+2
My iPod nano 2G works fine at r30586.
Comment by Michael Sevakis (MikeS) - Saturday, 01 October 2011, 10:35 GMT+2
Maybe this one! Tries a static buffer instead of using the audio buffer.
   usb-pp-storage-static-buffer.patch (1.2 KiB) 
 firmware/usbstack/usb_storage.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comment by Andree Buschmann (Buschel) - Saturday, 01 October 2011, 10:38 GMT+2
No effect.
Comment by Michael Sevakis (MikeS) - Saturday, 01 October 2011, 11:05 GMT+2
ok, gotta think. so far, video is the only one confirmed to be affected as such.
Comment by Bertrik Sikken (bertrik) - Saturday, 01 October 2011, 12:44 GMT+2
I can check on the ipod nano 1g (PP based) as soon as I get back home again (tomorrow)
Comment by Andree Buschmann (Buschel) - Saturday, 01 October 2011, 15:22 GMT+2
This patch fixes the issue. I am not sure about impacts though...
   usb_v03.patch (3.4 KiB) 
 firmware/target/arm/usb-drv-arc.c |   93 +++++++++++++++++++++++++-------------
 1 file changed, 62 insertions(+), 31 deletions(-)

Comment by Andree Buschmann (Buschel) - Saturday, 01 October 2011, 15:31 GMT+2
Condensed patch.
   usb_v04.patch (0.3 KiB) 
 firmware/target/arm/usb-drv-arc.c |    1 +
 1 file changed, 1 insertion(+)

Comment by Michael Sevakis (MikeS) - Saturday, 01 October 2011, 21:39 GMT+2
@Andree: the v04 patch with one line also works by itself, without the reversion of v03 (which I don't think we want since we know it's not a reliable host detection method)?
Comment by Andree Buschmann (Buschel) - Saturday, 01 October 2011, 22:11 GMT+2
v04 works as stand-alone patch. v03 was just the first quick shot, I could reduce it to the single one line in v04.

Loading...