This is the bug/patch tracker for Rockbox. Click here for more information.
Quick links: Bugs · Patches · Rockbox frontpage
FS#12319 - HiFiMAN HM-601 initial work
Attached to Project:
Rockbox
Opened by Andrew Ryabinin (mortalis) - Thursday, 06 October 2011, 22:50 GMT+2
Last edited by Marcin Bukat (MarcinBukat) - Monday, 17 October 2011, 12:33 GMT+2
Opened by Andrew Ryabinin (mortalis) - Thursday, 06 October 2011, 22:50 GMT+2
Last edited by Marcin Bukat (MarcinBukat) - Monday, 17 October 2011, 12:33 GMT+2
|
DetailsInitial work for HiFiMAN HM-601 audio player.
hm601.patch
(29 KiB)
bootloader/SOURCES | 2 tools/configure | 27 ++ apps/SOURCES | 4 apps/keymaps/keymap-hm601.c | 92 +++++++ firmware/export/config.h | 4 firmware/export/config/hm601.h | 184 +++++++++++++++ firmware/SOURCES | 11 firmware/target/arm/rk27xx/hm601/button-hm601.c | 46 +++ firmware/target/arm/rk27xx/hm601/button-target.h | 44 +++ firmware/target/arm/rk27xx/hm601/power-hm601.c | 48 +++ firmware/target/arm/rk27xx/hm601/powermgmt-hm601.c | 66 +++++ firmware/target/arm/rk27xx/hm601/lcd-hm601.c | 254 +++++++++++++++++++++ 12 files changed, 777 insertions(+), 5 deletions(-) |
This task depends upon
Closed by Marcin Bukat (MarcinBukat)
Monday, 17 October 2011, 12:33 GMT+2
Reason for closing: Accepted
Additional comments about closing: commited as r30765
Monday, 17 October 2011, 12:33 GMT+2
Reason for closing: Accepted
Additional comments about closing: commited as r30765
1) firmware/export/config.h - define for HM601_PAD is misaligned
2) firmware/export/config/hm601.h - we tend to call configuration files with vendormodel.h scheme
define for RK27XX_CODEC is wrong apparently and this should be refined
3) firmware/target/arm/rk27xx/hm601/button-hm601.c - in firmware/target/arm/rk27xx/adc-target.h there are defines for adc channel numbers. As channel 1 is used for buttons on all rk27xx players using such key reading scheme I ever saw, I think ADC_UNKNOWN_1 should be changed to ADC_BUTTONS and used in your button_read_device()
4) firmware/target/arm/rk27xx/hm601/lcd-hm601.c - there is huge code duplication. There should be separated LCDIF setup part which is common to all rk27xx devices and panel/driver specific part. Additionally look at current svn - I implemented partial updates which speedup things quite a bit. You can shape something similar in your driver.
Fixed 3 first points + some buttons bugs.
Added audio driver.
2) Your tda1543.{ch} are wrong. You should define valid volume range in audiohw_settings[] because our settings code depends on this.
3) What is output amp used in this DAP? Does it have fixed gain (simple opamp setup) or one can control attenuation? If output stage has fixed gain you need to setup vol control with help of our dsp engine (look how ondas do that).
4) I still think lcd driver should be factored out into two parts a) lcdif setup common to all rk27xx devices b) lcd controller specific part.
5) It would be nice to workout sound output before commiting.
Is it possible to disable volume control in rockbox at all?
Playback isn't working. Played time is allways 0:00, as though pause pressed.
New patch:
- Seareted lcdif and lcd parts
- Implemented lcd partial updates
Here is correct one
Your change to i2s_init() is not correct - this is perfectly possible (and judging from SDK sources used in practice) to have external codec working as i2s master. We have CODEC_SLAVE define which should be exploited here.
Is playback choppy or smooth?
./pll_settings 11289600
will give you 6 possible settings to get 'nice' frequency and stay within limits
Also changed target name to hm60x cause hm-601/hm-602/hm-603 have same hardware.