Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#12322 - Switch to SYS mode on arm

Attached to Project: Rockbox
Opened by Marcin Bukat (MarcinBukat) - Friday, 07 October 2011, 21:27 GMT+2
Last edited by Marcin Bukat (MarcinBukat) - Tuesday, 11 October 2011, 18:18 GMT+2
Task Type Bugs
Category Battery/Charging
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.9
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Currently our code runs in SVC mode most of the time. This isn't very wise since a) this prevents us from using SWI because b) entering SWI would corrupt LR. Moreover our current SWI handler simply returns and this may potentially produce errors hard to track down. This patch do two things a) setups SYS mode as default b) explicitly calls UIE on SWI.
   arm_sys_mode.diff (29.7 KiB) 
 b/firmware/target/arm/at91sam/lyre_proto1/crt0.S |   36 ++++++++----
 b/firmware/target/arm/crt0-pp-bl.S               |    2 
 b/firmware/target/arm/crt0-pp.S                  |   68 ++++++++++++-----------
 b/firmware/target/arm/crt0-pp502x-bl-usb.S       |   35 ++++++-----
 b/firmware/target/arm/crt0.S                     |   36 ++++++------
 b/firmware/target/arm/imx233/crt0.S              |   35 ++++++-----
 b/firmware/target/arm/imx31/crt0.S               |   34 ++++++-----
 b/firmware/target/arm/pnx0101/crt0-pnx0101.S     |   37 +++++++-----
 b/firmware/target/arm/rk27xx/crt0.S              |   41 +++++++------
 b/firmware/target/arm/s3c2440/crt0.S             |   39 +++++++------
 b/firmware/target/arm/s5l8700/crt0.S             |   34 ++++++-----
 b/firmware/target/arm/s5l8702/crt0.S             |   34 ++++++-----
 b/firmware/target/arm/system-arm.c               |    3 -
 b/firmware/target/arm/tcc77x/crt0.S              |   23 ++++---
 b/firmware/target/arm/tcc780x/crt0.S             |   23 ++++---
 b/firmware/target/arm/tms320dm320/crt0.S         |   25 +++++---
 16 files changed, 285 insertions(+), 220 deletions(-)

This task depends upon

Closed by  Marcin Bukat (MarcinBukat)
Tuesday, 11 October 2011, 18:18 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  commited as r30741
Comment by Bertrik Sikken (bertrik) - Friday, 07 October 2011, 22:49 GMT+2
All of my players I tested so far still boot and play music:
* Sansa c200 (PP5022)
* Sansa e200 (PP5024)
* Clipv1 (AMSv1)
* Clipv2 (AMSv2)
Comment by amaury pouly (pamaury) - Saturday, 08 October 2011, 14:55 GMT+2
It works on the fuze+ (i.MX233) for both bootloader and firmware. I've just checked that it boots.

Loading...