Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#12323 - Touchscreen: Show line separator in lists

Attached to Project: Rockbox
Opened by Thomas Martitz (kugel.) - Saturday, 08 October 2011, 01:05 GMT+2
Last edited by Thomas Martitz (kugel.) - Friday, 18 January 2013, 18:09 GMT+2
Task Type Patches
Category User Interface
Status Closed
Assigned To Thomas Martitz (kugel.)
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.9
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch adds the ability to show a horizontal line separator in lists, as a visual indicator for the list lines.

It's configurable in the theme menus, where it can be enabled and its color be changed.

As this is a theme setting, cabbiev2 is updated to include this setting. I think it includes it on all targets because I don't think wpsbuild has the magic to make stuff touchscreen specific.

Apply  FS#12321  before this.
   list-line-sep-1.patch (7.9 KiB) 
 b/apps/gui/bitmap/list.c  |   16 ++++++++++++++++
 b/apps/lang/english.lang  |   28 ++++++++++++++++++++++++++++
 b/apps/menus/theme_menu.c |   13 ++++++++++++-
 b/apps/settings.h         |    2 ++
 b/apps/settings_list.c    |    5 +++++
 b/wps/WPSLIST             |    4 ++++
 b/wps/wpsbuild.pl         |   29 ++++++++++++++++++++++++-----
 7 files changed, 91 insertions(+), 6 deletions(-)

This task depends upon

Closed by  Thomas Martitz (kugel.)
Friday, 18 January 2013, 18:09 GMT+2
Reason for closing:  Not a Bug
Additional comments about closing:  http://gerrit.rockbox.org/384
Comment by Jonathan Gordon (jdgordon) - Saturday, 08 October 2011, 15:37 GMT+2
another very wrong patch. this adds nothing that isnt already possible in the theme engine. And worse, it adds alot of cruft (voice+settings) for the majority of people who dont want and will never use it.
granted there is no skin tag to draw a horizontal line (though that was something I wanted to do for a while) doing that would be much smaller and less bloat for everyone else

Loading...