- Status Closed
- Percent Complete
- Task Type Bugs
- Category User Interface → Themes
- Assigned To No-one
- Operating System All players
- Severity Low
- Priority Medium
- Reported Version Daily build (which?)
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
FS#12336 - virtual keyboard spacing problem with custom keyboard and multifont theme
The virtual keyboard spacing is incorrect when using a custom loadable keyboard layout along with a theme which loads multiple fonts. The spacing of the virtual keyboard appears to be based on the largest font loaded, not the user interface font.
The first build that this behavior is noticeable is r30716, but that is not necessarily the failing build. With builds between r30589 and r30715, bringing up the virtual keyboard with a custom keyboard layout causes a data abort. The last build that works properly is r30588.
This is failure can be reproduced in the uisimulator.
Steps to reproduce:
1. Add a custom keyboard file to your .rockbox directory (http://www.rockbox.org/wiki/pub/Main/LoadableKeyboardLayouts/default.kbd is the default keyboard as a .kbd file)
2. Go to your .rockbox directory and "play" the file.
3. Bring up the virtual keyboard (i.e. rename a file) and notice the character spacing.
4. Load a theme which uses multiple fonts - you can modify the cabbiev2.wps file to load an additional larger font by adding a line such as:
%Fl(2,32-Terminus.fnt)
Make sure that font exists in your .rockbox/fonts directory. Also, change one of the viewport definitions to use the new font. Use a font which is large enough to be noticeable.
5. Bring up the virtual keyboard again. The spacing on the virtual keyboard has changed to match the size of the larger font which was loaded instead of the user interface font.
I have attached screendumps taken from the e200 sim. The correct.bmp screendump is using the default.kbd and an unmodified cabbiev2. The incorrect.bmp screendump has a cabbiev2 with the above %Fl line added and one viewport modified to use font number 2.
2011-10-22 19:49
Reason for closing: Fixed
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
Fixed in r30826.
Loading...
Available keyboard shortcuts
- Alt + ⇧ Shift + l Login Dialog / Logout
- Alt + ⇧ Shift + a Add new task
- Alt + ⇧ Shift + m My searches
- Alt + ⇧ Shift + t focus taskid search
Tasklist
- o open selected task
- j move cursor down
- k move cursor up
Task Details
- n Next task
- p Previous task
- Alt + ⇧ Shift + e ↵ Enter Edit this task
- Alt + ⇧ Shift + w watch task
- Alt + ⇧ Shift + y Close Task
Task Editing
- Alt + ⇧ Shift + s save task
This task may be related to
FS#12306Can you try this? It adds some code to track which font is FONT_UI. It seems to fix my v-keyboard and lrcplayer.
Fred,
This patch looks good to me. After a quick test, both the virtual keyboard (and lrcplayer -
FS#12306) seem to work properly.