FS#12351 : Sansa e200 - Scroll wheel usage doesn't restart power off timer

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

FS#12351 - Sansa e200 - Scroll wheel usage doesn't restart power off timer

Attached to Project: Rockbox
Opened by Nick Peskett (nickp) - Thursday, 27 October 2011, 06:09 GMT+2
Last edited by Andree Buschmann (Buschel) - Friday, 28 October 2011, 19:24 GMT+2

Task Type	Bugs
Category	User Interface
Status	Closed
Assigned To	No-one
Player Type	Sansa e200
Severity	Low
Priority	Normal
Reported Version	Release 3.9
Due in Version	Undecided
Due Date	Undecided
Percent Complete
Private	No

Details

Unlike other targets (examples below), moving the e200 scroll wheel doesn't restart the power off timer, so shutdown is possible even though the device obviously isn't idle.

http://svn.rockbox.org/viewvc.cgi/trunk/firmware/target/arm/ipod/button-clickwheel.c?annotate=30842#l142
http://svn.rockbox.org/viewvc.cgi/trunk/firmware/target/arm/ipod/button-1g-3g.c?annotate=30842#l101
http://svn.rockbox.org/viewvc.cgi/trunk/firmware/target/coldfire/mpio/hd300/button-hd300.c?annotate=30842#l107
http://svn.rockbox.org/viewvc.cgi/trunk/firmware/target/arm/philips/hdd6330/button-hdd6330.c?annotate=30842#l157
http://svn.rockbox.org/viewvc.cgi/trunk/firmware/target/arm/pbell/vibe500/button-vibe500.c?annotate=30842#l129

Here's a previous commit, fixing the problem for iPods;

http://svn.rockbox.org/viewvc.cgi?view=rev&revision=12068

Attached fix for device and simulator;

scrollwheel_idlestate_bug.patch (1 KiB)

 firmware/target/arm/as3525/scrollwheel-as3525.c |    1 +
 firmware/target/hosted/sdl/button-sdl.c         |    1 +
 2 files changed, 2 insertions(+)

This task depends upon

Closed by Andree Buschmann (Buschel)
Friday, 28 October 2011, 19:24 GMT+2
Reason for closing: Accepted
Additional comments about closing: Submitted with r30847.

Comments (4)
Related Tasks (0/0)

Comment by Nick Peskett (nickp) - Thursday, 27 October 2011, 06:15 GMT+2

Forgot to include powermgmt.h

scrollwheel_idlestate_bug_30842.patch (1.3 KiB)

 firmware/target/arm/as3525/scrollwheel-as3525.c |    2 ++
 firmware/target/hosted/sdl/button-sdl.c         |    2 ++
 2 files changed, 4 insertions(+)

Comment by Andree Buschmann (Buschel) - Friday, 28 October 2011, 08:35 GMT+2

I just tried on the sim. The timer is not restartet at all even though reset_poweroff_timer() is called.

Comment by Nick Peskett (nickp) - Friday, 28 October 2011, 08:47 GMT+2

Calling reset_poweroff_timer was the point of the exercise, maybe poweroff_timer isn't implemented on the sim?

Otherwise I imagine a bug ought to be submitted that the reset_poweroff_timer function doesn't work on the sim.

Comment by Andree Buschmann (Buschel) - Friday, 28 October 2011, 19:18 GMT+2

My fault, you always were talking about the "power off timer", I tested the "sleep timer"... :/

Your fix works for the sim.

	Tasks related to this task (0)

Duplicate tasks of this task (0)

Rockbox

FS#12351 - Sansa e200 - Scroll wheel usage doesn't restart power off timer

Details

Loading...