Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#12355 - First patch for HiFiMAN HM-801 target

Attached to Project: Rockbox
Opened by Andrew Ryabinin (mortalis) - Thursday, 27 October 2011, 20:35 GMT+2
Last edited by Andrew Ryabinin (mortalis) - Thursday, 03 November 2011, 13:04 GMT+2
Task Type Patches
Category Drivers
Status Closed
Assigned To No-one
Player Type Another
Severity Low
Priority Normal
Reported Version Release 3.9
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This is initial patch for HiFiMAN HM-801.
firmware/target/arm/rk27xx/hm60x/lcd-hm60x.c moved to firmware/target/arm/rk27xx/lcd-hifiman.c because all hifimans have same lcd.

HM801 have pcm1704 DAC and hm60x have tda1543. Both this DACs is not configurable, so audio codec is the same.
Thats why this patch rename tda1543.{ch} to dummy_codec.{ch}.
   hm801.patch (38.4 KiB)
 apps/SOURCES                                       |    2 
 apps/keymaps/keymap-hm801.c                        |  107 +++++++++++++
 bootloader/SOURCES                                 |    2 
 firmware/SOURCES                                   |   15 +
 firmware/drivers/audio/dummy_codec.c               |   46 +++++
 firmware/drivers/audio/tda1543.c                   |   46 -----
 firmware/export/audiohw.h                          |    4 
 firmware/export/config.h                           |    3 
 firmware/export/config/hifimanhm60x.h              |    2 
 firmware/export/config/hifimanhm801.h              |  171 +++++++++++++++++++++
 firmware/export/dummy_codec.h                      |   29 +++
 firmware/export/tda1543.h                          |   29 ---
 firmware/target/arm/rk27xx/debug-target.h          |    2 
 firmware/target/arm/rk27xx/hm60x/lcd-hm60x.c       |  148 ------------------
 firmware/target/arm/rk27xx/hm801/button-hm801.c    |   52 ++++++
 firmware/target/arm/rk27xx/hm801/button-target.h   |   47 +++++
 firmware/target/arm/rk27xx/hm801/power-hm801.c     |   49 ++++++
 firmware/target/arm/rk27xx/hm801/powermgmt-hm801.c |   64 +++++++
 firmware/target/arm/rk27xx/lcd-hifiman.c           |  148 ++++++++++++++++++
 firmware/target/arm/rk27xx/lcdif-rk27xx.c          |    2 
 firmware/target/arm/rk27xx/sd-rk27xx.c             |    8 
 tools/configure                                    |   24 ++
 22 files changed, 767 insertions(+), 233 deletions(-)

This task depends upon

Closed by  Andrew Ryabinin (mortalis)
Thursday, 03 November 2011, 13:04 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  commited as r30891
Comment by Marcin Bukat (MarcinBukat) - Thursday, 27 October 2011, 22:18 GMT+2
This is rather minor remark but you could use binary search in key reading routine to reduce number of comparisons (look at key driver for MPIO HD200/HD300 for reference). Keys are scanned every 10ms so this is reasonable to optimize this function.
Comment by Andrew Ryabinin (mortalis) - Friday, 28 October 2011, 11:09 GMT+2
binnary search in button driver
   hm801.patch (38.5 KiB)
 apps/SOURCES                                       |    2 
 apps/keymaps/keymap-hm801.c                        |  107 +++++++++++++
 bootloader/SOURCES                                 |    2 
 firmware/SOURCES                                   |   15 +
 firmware/drivers/audio/dummy_codec.c               |   46 +++++
 firmware/drivers/audio/tda1543.c                   |   46 -----
 firmware/export/audiohw.h                          |    4 
 firmware/export/config.h                           |    3 
 firmware/export/config/hifimanhm60x.h              |    2 
 firmware/export/config/hifimanhm801.h              |  171 +++++++++++++++++++++
 firmware/export/dummy_codec.h                      |   29 +++
 firmware/export/tda1543.h                          |   29 ---
 firmware/target/arm/rk27xx/debug-target.h          |    2 
 firmware/target/arm/rk27xx/hm60x/lcd-hm60x.c       |  148 ------------------
 firmware/target/arm/rk27xx/hm801/button-hm801.c    |   68 ++++++++
 firmware/target/arm/rk27xx/hm801/button-target.h   |   47 +++++
 firmware/target/arm/rk27xx/hm801/power-hm801.c     |   49 ++++++
 firmware/target/arm/rk27xx/hm801/powermgmt-hm801.c |   64 +++++++
 firmware/target/arm/rk27xx/lcd-hifiman.c           |  148 ++++++++++++++++++
 firmware/target/arm/rk27xx/lcdif-rk27xx.c          |    2 
 firmware/target/arm/rk27xx/sd-rk27xx.c             |    8 
 tools/configure                                    |   24 ++
 22 files changed, 783 insertions(+), 233 deletions(-)

Loading...