Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#12356 - next track advances when skip in repeat one mode

Attached to Project: Rockbox
Opened by Marcin Bukat (MarcinBukat) - Friday, 28 October 2011, 08:52 GMT+2
Last edited by Michael Sevakis (MikeS) - Saturday, 29 October 2011, 22:43 GMT+2
Task Type Bugs
Category Music playback
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.9
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Way to reproduce:
1) select file from file browser
2) change repeat to 'one'
3) skip doesn't change the file (that is expected) but next track displayed in WPS advances
This task depends upon

Closed by  Michael Sevakis (MikeS)
Saturday, 29 October 2011, 22:43 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Patch commed in r30857
Comment by Thomas Martitz (kugel.) - Friday, 28 October 2011, 09:05 GMT+2
For me (on RaaA), skip does change the file. Then the WPS plays track 2, and shows track 3 as next track. Skipping again goes back to the selected file (track 1).
Comment by Michael Sevakis (MikeS) - Friday, 28 October 2011, 15:23 GMT+2
I'm not personally observing this yet but I can only see playback getting different files if in fact the playlist give the playback engine another path. Repeat One should result in the engine seeing the same path over and over again in an endless loop.
Comment by Michael Sevakis (MikeS) - Friday, 28 October 2011, 15:25 GMT+2
One possibility comes to mind, that if this happens only going from "none" to "one" then a proper flush and reload of the playlist isn't happening in some cases.
Comment by Thomas Martitz (kugel.) - Friday, 28 October 2011, 15:32 GMT+2
My case is when going from none to one
Comment by Thomas Martitz (kugel.) - Saturday, 29 October 2011, 17:33 GMT+2
I can see wodz' behavior when going from repeat all to one.
Comment by Michael Sevakis (MikeS) - Saturday, 29 October 2011, 20:27 GMT+2
From which screen is repeat mode being changed? I see the quickscreen calls audio_flush_and_reload_tracks. Perhaps that call is missing elsewhere.
Comment by Michael Sevakis (MikeS) - Saturday, 29 October 2011, 21:12 GMT+2
I tried from the playback menu and of course it didn't have the needed call. These complex settings should be done through a single call that handles the change properly as is done with cuesheets and crossfade.

So, here's a patch that takes care of that. Enlighten me of more places repeat_mode gets changed that I might have missed.
   fix-repeat-mode-setting-oversight.patch (1.6 KiB) 
 apps/menus/playback_menu.c |   26 +++++++++++++++++++++++---
 1 file changed, 23 insertions(+), 3 deletions(-)

Comment by Thomas Martitz (kugel.) - Saturday, 29 October 2011, 21:16 GMT+2
You can change settings in skins with some tag. I don't know where/how it's implemented, though.
Comment by Michael Sevakis (MikeS) - Saturday, 29 October 2011, 21:21 GMT+2
Ah, thanks. It turns out that one has the needed call.
Comment by Thomas Martitz (kugel.) - Saturday, 29 October 2011, 21:31 GMT+2
Repeat mode touchregion seems also fine
Comment by Michael Sevakis (MikeS) - Saturday, 29 October 2011, 21:50 GMT+2
Ought I commit this? I saw the reported behavior without it and it did the trick to resync playback in the menu case.
Comment by Thomas Martitz (kugel.) - Saturday, 29 October 2011, 22:27 GMT+2
Looks good to me

Loading...