- Status Closed
- Percent Complete
- Task Type Bugs
- Category Playlists
- Assigned To No-one
- Operating System All players
- Severity Low
- Priority Very Low
- Reported Version Daily build (which?)
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
Opened by dreamlayers - 2011-12-31
Last edited by dreamlayers - 2011-12-31
FS#12499 - Directory playback fails after saving playlist
With a real 5G iPod or sim running r31467, directory playback stops working after I save a playlist. To reproduce: play a directory, save the playlist, stop playback, and try to play a directory again. The error is “Playlist Buffer Full”.
This happens because the end of playlist_save() sets playlist→buffer = NULL and playlist→buffer_size = 0. The zero buffer_size causes playlist_add() to fail near the start of the function and display that error. When the current playlist file is being overwritten, playlist_save() correctly saves and restores the values, but otherwise, the values aren’t saved and they are “restored” from variable initializations at the start.
My patch here solves the problem by unconditionally saving old_buffer and old_buffer_size. (Compared to conditionally restoring the values, it’s simpler and it results in smaller binsize.) I removed buffer_handle saving because it’s not altered in playlist_save(). The patch also initializes buffer_handle in playlist_init().
2011-12-31 16:53
Reason for closing: Fixed
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
Fixed in r31481
Loading...
Available keyboard shortcuts
- Alt + ⇧ Shift + l Login Dialog / Logout
- Alt + ⇧ Shift + a Add new task
- Alt + ⇧ Shift + m My searches
- Alt + ⇧ Shift + t focus taskid search
Tasklist
- o open selected task
- j move cursor down
- k move cursor up
Task Details
- n Next task
- p Previous task
- Alt + ⇧ Shift + e ↵ Enter Edit this task
- Alt + ⇧ Shift + w watch task
- Alt + ⇧ Shift + y Close Task
Task Editing
- Alt + ⇧ Shift + s save task