Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#12520 - iPod Classic/6G: holdswitch PMU polling crashes

Attached to Project: Rockbox
Opened by Cástor Muñoz (prof_wolfff) - Sunday, 08 January 2012, 22:05 GMT+2
Last edited by MichaelGiacomelli (saratoga) - Wednesday, 11 April 2012, 03:59 GMT+2
Task Type Bugs
Category Operating System/Drivers
Status Closed
Assigned To No-one
Player Type Another
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

There are some random crashes that usually occurs when the scrollwheel is used is WPS, moving PMU polling (for holdswitch status) from ISR to powermgmt thread seems to fix this problem for me.

i choose this approach as a first attempt because it is fast to implement and simple, maybe a better future solution is to make i2c functions IRQ safe, but it is not so trivial and may affect other functionality.
   ipod6g_holdswitch_poll-v1.patch (3.6 KiB) 
 firmware/target/arm/s5l8702/ipod6g/button-target.h |    1 
 firmware/target/arm/ipod/button-clickwheel.c       |   32 ++++++++++++---------
 firmware/powermgmt.c                               |   12 +++++++
 3 files changed, 32 insertions(+), 13 deletions(-)

This task depends upon

View Dependency Graph

This task blocks these from closing
 FS#12521 - iPod Classic/6G: cpu freq scaling 
Closed by  MichaelGiacomelli (saratoga)
Wednesday, 11 April 2012, 03:59 GMT+2
Reason for closing:  Accepted
Comment by Albert Barca (axismundi) - Monday, 13 February 2012, 23:47 GMT+2
I've been using this for a few weeks, together with #12521 (and #12523). I get much fewer crashes, as a matter of fact they are almost non-existent. Looks like we have a winner. Once again a good job, thanks Castor!

Loading...