Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#12523 - IPod Classic/6G: LCD sleep

Attached to Project: Rockbox
Opened by Cástor Muñoz (prof_wolfff) - Monday, 09 January 2012, 01:51 GMT+2
Last edited by Nils Wallménius (nls) - Saturday, 25 February 2012, 13:50 GMT+2
Task Type Patches
Category LCD
Status Closed
Assigned To No-one
Player Type Another
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch implements HAVE_LCD_SLEEP, currently iit only supports lcd_type=1 displays (you can see your LCD type at Menu->System->Debug->HW Info), lcd_type=0 should work but isn't tested. I think that support for lcd_types 2 and 3 will work using initialization sequences from emCORE loader, but need some testers.

   ipod6g_lcd_sleep-v1.patch (2.9 KiB) 
 firmware/target/arm/s5l8702/ipod6g/backlight-ipod6g.c |    8 +--
 firmware/target/arm/s5l8702/ipod6g/lcd-ipod6g.c       |   47 +++++++++++++++++-
 firmware/export/config/ipod6g.h                       |    4 -
 3 files changed, 52 insertions(+), 7 deletions(-)

This task depends upon

Closed by  Nils Wallménius (nls)
Saturday, 25 February 2012, 13:50 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Comitted, thanks!
Comment by MichaelGiacomelli (saratoga) - Monday, 09 January 2012, 02:58 GMT+2
Have you had a chance to do a battery bench since you implemented all these improvements? I'm curious how much power you save.
Comment by Cástor Muñoz (prof_wolfff) - Monday, 09 January 2012, 07:08 GMT+2
My battery was nos used very much on the past, iI doubled playing time (vs SVN version 27999) using CPU scaling + LCD sleep, now i get approx. 22h playing FLAC and 24h playing mp3 @320 (one continuous run playing different music files).
Comment by Bruce (fleasbaby) - Friday, 03 February 2012, 03:48 GMT+2
Hi Castor,

A fellow Head-Fi board member was kind enough to compile your recent patches to the Classic build, and all work perfectly so far, except for this one. I have a 160GB Classic (the fatter one) with LCD 3. This patch causes the now playing screen to frieze (halting all indicators of how much time in the track has elapsed, etc). Touching any button on the clickwheel causes the screen to refresh, but it instantly friezes thereafter.

I would be more than happy to test for you if you would like...
Comment by Adam (SenorLoco) - Friday, 03 February 2012, 13:12 GMT+2
Hey Castor,

If you are looking for testers, I'm seeing the same issue is with LCD type 2.
Comment by Cástor Muñoz (prof_wolfff) - Saturday, 04 February 2012, 07:55 GMT+2
I am glad you are using these patches and they are working ok, the lcd sleep patch doesn't support type 2 and 3 LCD displays, i wrote it to not to cause side effects on these displays but cannot test it, probably something is wrong and the display is not updated, do not install v1 patch on LCD type 2 and 3.

You are welcome if you want to test these displays, AFAIK there is no info about the displays, theSeven and freemyipod team made the emCore loader and the Rockbox port analysing OF, i think the only thing i can do is to include the initialisation sequence used in the loader, don't know if it will work, this sequence is the same as in OF (i think) so it shouldn't harm the ipod. Unfortunately i don't have too much free time so please be patient, i will try to post a patch including this sequence as soon as possible. Bruce, i am curious about the LCD type 2 ipod model.

Comment by Bruce (fleasbaby) - Saturday, 04 February 2012, 15:43 GMT+2
Hi Castor,

Whenever you have an updated version, throw together a build and I will be glad to give it a run through. I have a type 3 LCD iPod Classic...Adam (Senor Loco) has a type 2...

Take your time, I understand the pressures of daily life (as I type my little daughter is emptying the desk drawer onto the floor...naughty little bugger).
Comment by Albert Barca (axismundi) - Tuesday, 14 February 2012, 00:01 GMT+2
Works very well for me (LCD1, 80GB and 120GB Classics). I am using this in conjunction with #12520 and #12521, as mentioned in the respective threads I can see the benefits (I did not bother making any measurements though).
Comment by Cástor Muñoz (prof_wolfff) - Monday, 20 February 2012, 20:56 GMT+2
Version 2 of this patch supports all LCD types (not tested on LCD type 0), many thanks to Bruce and Adam for beta-testing it on their LCD type 2 and 3 iPods, when sleeping these displays go to Deep-Standby mode resulting on a very low power consumption. To awake the display this patch implements the same init sequence used by emCORE loader, other needed info was obtained from ILI9320 and ILI9326 datasheets.

   ipod6g_lcd_sleep-v2.patch (10.2 KiB) 
 firmware/export/config/ipod6g.h                       |    4 
 firmware/target/arm/s5l8702/ipod6g/backlight-ipod6g.c |   10 
 firmware/target/arm/s5l8702/ipod6g/lcd-ipod6g.c       |  267 +++++++++++++++---
 3 files changed, 235 insertions(+), 46 deletions(-)

Loading...