Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#12542 - Rockbox Utility warning on compiling

Attached to Project: Rockbox
Opened by Jean-Louis Biasini (JeanLouisBiasini) - Tuesday, 17 January 2012, 15:43 GMT+2
Last edited by Dominik Riebeling (bluebrother) - Tuesday, 17 January 2012, 22:05 GMT+2
Task Type Patches
Category Rbutil
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.10
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

While compiling Rockbox Utility ones get the following error:
base/system.cpp: In static member function ‘static QMap<unsigned int, QString> System::listUsbDevices()’:
base/system.cpp:249:9: warning: variable ‘res’ set but not used [-Wunused-but-set-variable]
base/system.cpp:250:13: warning: variable ‘count’ set but not used [-Wunused-but-set-variable]

count and res are just used to take the return values of libusb_init() and libusb_get_device_list but do not get used later...

the following patch let those fonction being called without saving their return value in any variable.
   rbutil-warn-patch-v1.diff (0.6 KiB) 
 b/rbutil/rbutilqt/base/system.cpp |    7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

This task depends upon

Closed by  Dominik Riebeling (bluebrother)
Tuesday, 17 January 2012, 22:05 GMT+2
Reason for closing:  Fixed
Additional comments about closing:  Thanks, but I've decided to check the actual values instead of ignoring them.

Loading...