Warning: mysqli_real_connect(): Headers and client library minor version mismatch. Headers:50625 Library:50543 in /sites/rockbox.org/flyspray/adodb/drivers/adodb-mysqli.inc.php on line 108 FS#12570 : 10 bands EQ



FS#12570 - 10 bands EQ

Attached to Project: Rockbox
Opened by Albert Barca (axismundi) - Sunday, 29 January 2012, 15:55 GMT
Last edited by MichaelGiacomelli (saratoga) - Monday, 15 April 2013, 20:22 GMT
Task Type Patches
Category Settings
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Release 3.10
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


Extends the number of EQ bands from 5 (2 shelf and 3 peak filters) to 10 (2 shelf and 8 peak filters). Some users will find this useful, in particular those that prefer not to use the shelf filters.

It should work on all targets; the bands become active only if their amplitude is changed from 0dB.

Not rocket science but I could not find any patch covering this so I had to write my own, I know some other users were looking for something similar.
This task depends upon

Closed by  MichaelGiacomelli (saratoga)
Monday, 15 April 2013, 20:22 GMT
Reason for closing:  Accepted
Comment by Seheon Ryu (cpu98) - Saturday, 04 February 2012, 05:46 GMT
I've been using more bands on rb personally, sometimes found 3 peak filters are somewhat limiting.
DAPs are coming with powerful CPUs, I think it's good to increase default eq bands.

30, 60, 120, 250, 500, 1k, 2k, 4k, 8k, 16k are ISO 266 Preferred frequencies(octave band), rounded to the nearest geometric mean.
(30 ~ 120 ones due to 10Hz resolution on current code) and that's nice.

Band 4(shelf) of current eq presets should be moved to band 9.

It's also good for spec sheet.
Comment by Albert Barca (axismundi) - Saturday, 04 February 2012, 22:13 GMT
I also think that the current DAPs CPUs have more than sufficient power to allow the use of more eq bands. Plus bands become active only when gain is different from 0dB, basically having more than 5 bands brings benefits at no cost for those that don't really need more...

> Band 4(shelf) of current eq presets should be moved to band 9.

What do you mean by that? Band 9 (or 10 if you count from 1) is already the high shelf in this patch...
Comment by Seheon Ryu (cpu98) - Sunday, 05 February 2012, 03:03 GMT
I meant existing eq presets in eq folder. Yeah that can be done later...
Comment by Albert Barca (axismundi) - Monday, 06 February 2012, 22:10 GMT
> I meant existing eq presets in eq folder

I get it. Good point indeed, as a matter of fact all the presets could/should be modified in order take advantage of the 10 bands. I'll look into this when I have a little more time.
Comment by Fred Bauer (freddyb) - Tuesday, 20 March 2012, 20:31 GMT
This is just a re-sync of the original patch to current git with a new 10 band preset: default.cfg. No warranty.
Comment by MichaelGiacomelli (saratoga) - Sunday, 25 November 2012, 22:38 GMT
I'm ok with committing this, but:

1) It needs manual changes to go with it (probably just changing the number of bands listed in the text)
2) It should probably only be enabled for devices that are actually fast enough to run it.

I'm guessing #2 means all ARMv5E and newer devices, although someone might want to test on coldfire and see if it can handle it.