Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#12616 - Clip+ Radio Keymap More Consistent

Attached to Project: Rockbox
Opened by Shiloh Hawley (gree665) - Wednesday, 14 March 2012, 06:17 GMT+2
Last edited by MichaelGiacomelli (saratoga) - Sunday, 25 November 2012, 22:10 GMT+2
Task Type Patches
Category FM Tuner
Status Closed
Assigned To No-one
Player Type Sansa AMSv2
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This makes the Radio screen buttons similar to the WPS buttons:
The differences:
-Home now brings you to root menu screen.
-Stop now stops playing and brings you to the root menu screen.
-Long Select toggles the scan/preset modes.

   clip-radio-buttons.patch (1.7 KiB) 
 b/apps/keymaps/keymap-clip.c |   14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

This task depends upon

Closed by  MichaelGiacomelli (saratoga)
Sunday, 25 November 2012, 22:10 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Accepted in f6d088c.
Comment by Dominik Riebeling (bluebrother) - Wednesday, 14 March 2012, 23:55 GMT+2
As far as I can see this patch was made using git. Please use gerrit for patches if possible. Also, at least I would appreciate the appropriate change to the manual as well.

(Can't comment if the changed button mappings make sense / are useful since I don't own a Clip)
Comment by Shiloh Hawley (gree665) - Thursday, 15 March 2012, 05:04 GMT+2
I just figured out how to update the code with git, and I was looking for information about how to use gerrit, but I wasn't sure if it is set up for people without commit status or not. Apparently it is, so I will look into it.

I don't know how to make a patch for the manual, but the change needed is in: Section 5.9 FM Radio, in the the key/action table. The 3 that are changed marked with *(notes).

KEY ACTION
Left, Right Change frequency in SCAN mode or jump to next/previous station in PRESET mode.
Long Left, Long Right Seek to next station in SCAN mode.
Volume Up, Volume Down Change volume.
Power Stop the radio and return to Main Menu. *(now behaves similarly to WPS)
Home Leave the radio screen with the radio playing. *(now behaves similarly to WPS, bringing you to root menu, then back to Radio screen)
Play Mute radio playback.
Long Select Switch between SCAN and PRESET mode. *(used to be of home key)
Select Open a list of radio presets. You can view all the presets that you have, and switch to the station.
Submenu Display the FM radio settings menu.

Comment by Shiloh Hawley (gree665) - Thursday, 15 March 2012, 05:06 GMT+2
Hmm Seems that submitting the comment messed up my columns there.
Comment by Václav Brožík (pabouk) - Tuesday, 10 April 2012, 10:46 GMT+2
Great, thanks for the patch! It is really a mess to have a different keymaps in different screens.

Could you please map Long Select to the FM Radio Menu to be consistent with mapping to the Context Menu in other places?
Switching scan/preset modes could be probably long Up or long Down.
Comment by Shiloh Hawley (gree665) - Wednesday, 11 April 2012, 18:02 GMT+2
You're right, long select should be the context menu for radio. I'll make the change.
Comment by Shiloh Hawley (gree665) - Tuesday, 24 April 2012, 14:28 GMT+2
Ok I swapped the menu and the scan mode features. Here is the comparison with the WPS buttonmap:

ACTION WPS RADIO
Volume Up /Volume Down -Volume up/down -Volume up/down
Left/Right -Change track -Change station
Long Left/Right -Rewind/Fast forward. -Next station in SCAN mode.
Play -Toggle pause -Toggle mute
Long Play -Pitch screen -N/A
Power -Stop playback -Stop Radio (goes to main menu)
Select -File Browser/Database -Radio Presets
Long Select -Enter WPS Context Menu -Radio Menu
Home -Main Menu (still playing) -Main Menu (still playing)
Long Home -Switch to the Quick Screen -N/A
Home+Select Key -Toggle hold -N/A
Submenu -N/A -Switch between SCAN and PRESET
Long Submenu -Show current Playlist -N/A
   clip_radio_buttons.patch (1.8 KiB) 
 b/apps/keymaps/keymap-clip.c |   16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

Comment by MichaelGiacomelli (saratoga) - Saturday, 24 November 2012, 03:00 GMT+2
I've update the above patch with manual changes. If no one minds, I'll commit this version.
   radio_manual.patch (2.6 KiB) 
 b/apps/keymaps/keymap-clip.c           |   16 ++++++++--------
 b/manual/platform/keymap-sansaclip.tex |    8 ++++----
 2 files changed, 12 insertions(+), 12 deletions(-)

Loading...