Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#12779 - This patch reworks the sleep timer a little bit and fixes a small bug.

Attached to Project: Rockbox
Opened by Kai Posadowsky (Riffer) - Thursday, 08 November 2012, 22:40 GMT+2
Last edited by Dominik Riebeling (bluebrother) - Friday, 09 November 2012, 21:17 GMT+2
Task Type Patches
Category Music playback
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.11
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

After seeing that nearly all what I wanted to have regarding the sleep timer I had only one point left: The sleep timer should not shut down but instead turn into pause playing. After this the standard poweroff timer gets to work. If the poweroff timer is not set the sleep timer directly shuts down as before.

This fixes a bug too - there was a pause on sleep timer end but only for the situation where usb (I think mostly for battery purpose?) is connected. But after that the sleep timer won't be restarted on button use! This has been fixed now.
This task depends upon

Closed by  Dominik Riebeling (bluebrother)
Friday, 09 November 2012, 21:17 GMT+2
Reason for closing:  Out of Date
Additional comments about closing:  Patch is now on gerrit: http://gerrit.rockbox.org/r/#/c/349/
Comment by Kai Posadowsky (Riffer) - Thursday, 08 November 2012, 22:41 GMT+2
here the patch itself
   sleeptimer.patch (1.7 KiB) 
 b/firmware/powermgmt.c |   14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

Comment by Dominik Riebeling (bluebrother) - Thursday, 08 November 2012, 23:05 GMT+2
We prefer patches on gerrit these days. Is it possible for you to push it there?
Comment by Kai Posadowsky (Riffer) - Friday, 09 November 2012, 20:17 GMT+2
After having a good time with gerrit (maybe the instructions should say very clearly that the Username is case sensitive?) its done:

http://gerrit.rockbox.org/r/#/c/349/


Comment by Kai Posadowsky (Riffer) - Friday, 09 November 2012, 21:13 GMT+2
(forget about the case sensitive, I just added it - nice to be part of the team!)

Someone could lease close this. Many thanks!
Comment by Kai Posadowsky (Riffer) - Friday, 09 November 2012, 21:14 GMT+2
*please

Loading...