Rockbox

  • Status Closed
  • Percent Complete
    0%
  • Task Type Patches
  • Category User Interface → Themes
  • Assigned To No-one
  • Operating System
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by cent20 - 2003-08-27
Last edited by linusnielsen - 2005-07-06

FS#1660 - A-B Repeat

as the title says. When in this mode, push ON to set
both positions and to unset them afterwards.

Closed by  linusnielsen
2005-07-06 21:01
Reason for closing:  Out of Date

Sounds like a nice feature, but dosen’t this make it where you
can’t go to the browser while playing?

If you select the mode, yes, but you just have to press F2
and change back to another one. Or go to the menu if you
got a player. I considered this but i don’t think it’s a problem,
it wouldn’t be easier to have to push some combination that
would be compatible with the player as well.

Project Manager

cent20,

Could you please try to only include the relevant changes in
the patch file? There are lots of whitespace differences,
making it hard for me to see what is changed by just
browsing the patch file.

alright. I was in trouble cos of the icons and tried a few
things so i left a lot of white spaces everywhere.

that’s it!

Precision improved by adding an ab repeat thread.

Another version with code included in the mpeg thread. Has
some advantages and disadvantages. It’s not that precise
anyway (could be better), and i don’t think it’s better than
the first precision improvement. The last step would be to
integrate the time check to the thread itself and then bypass
the event queue.

I have been waiting for this feature for a while. This is what
was on my Rio 300 (the first mp3 player) and I loved it!

Just in case you didn’t see it, the argument passed to
mpeg_ff_rewind() was changed (actual time instead of
offset). You’ll probably want to update your patch.

Some bug fixes regarding AB repeat icons here. Else :
- doesn’t loop the playlist anymore, as if it was in repeat all
mode.
- patch is made for daily-20030830 so with the new
mpeg_ff_rewind function.

New addition :

If both markers are set, pushing ON for 0.5 sec shows up a
menu which allows modifying those.

Patch for daily-20030830.

Anonymous Submitter commented on 2004-01-21 19:33

This patch appears to be broken with the more current
versions of rockbox (since mid-December through to now):

7 hunks fail to be patched…settings_menu.c, mpeg.h, and
others. Does anyone have any luck with this?

sherv commented on 2004-01-21 19:37

This patch appears to be broken with the more current
versions of rockbox (since mid-December through to now):

7 hunks fail to be patched…settings_menu.c, mpeg.h, and
others. Does anyone have any luck with this?

Anonymous Submitter commented on 2004-01-27 16:49

Yes, I have applied it recently. I will update it and upload it
ASAP.

sherv commented on 2004-01-27 17:16

Great!! This patch will be an excellent addition to Rockbox,
and I really appreciate the work done on it!

Anonymous Submitter commented on 2004-05-08 06:32

No progress on this patch? :(

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing