- Status Closed
- Percent Complete
- Task Type Patches
- Category ID3 / meta data
- Assigned To No-one
- Operating System
- Severity Low
- Priority Very Low
- Reported Version
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
FS#1943 - honor the rva2/xrva/xrv frame
Hi,
last friday I received my jukebox recorder 15 and put
rockbox
on it. I did run all my mp3 files through normalize a
couple of month ago. They all have id2.3 tags with an
XRVA frame.
I did not try the code with id1 XRV or id2.4 RVA2 frames.
I put code into rockbox to honor this frame (as good as
possible). Aktually updating the volume is only done for
the recorder.
regards, Matthias (leo@marco.de)
Loading...
Available keyboard shortcuts
- Alt + ⇧ Shift + l Login Dialog / Logout
- Alt + ⇧ Shift + a Add new task
- Alt + ⇧ Shift + m My searches
- Alt + ⇧ Shift + t focus taskid search
Tasklist
- o open selected task
- j move cursor down
- k move cursor up
Task Details
- n Next task
- p Previous task
- Alt + ⇧ Shift + e ↵ Enter Edit this task
- Alt + ⇧ Shift + w watch task
- Alt + ⇧ Shift + y Close Task
Task Editing
- Alt + ⇧ Shift + s save task
Why is an RVA tag better than the method mp3gain uses,
which requires no extra player support?
I didn’t know about mp3gain. One nice thing about the RVA tag is
that “normalize” doesn’t touch the mp3 data at all. And all
my mp3
files already have a RVA tag…
Matthias
And another nice thing about rva is that you can turn it off, if
you wish to listen to a album or track without volume
adjustment.
Matthias
Hi Matthias,
I would like to include this patch in the new Cyborg Systems
branch of Rockbox with all the enhanced audio features.
I would like to do it with your blessing as I think this is a great
audio enhancement.
Bluechip
http://homepage.ntlworld.com/cyborgsystems
because the method which mp3gain uses cannot be undo-ed,
unless the undo-data is stored somewhere else(i.e. in a tag)
- loose the undo data, and the changes cannot be reversed
anymore.
With a tag-based solution, things are different: if you
loose the tag, then the changes are undo-ed. Thus, there is
no risk for accidental permanent change of the file.
with a tag you can also have separate album gain and track gain, but i don’t know if the mp3 tags let you do that.. ogg does at least.
Rockbox on software codec platforms has full Replaygain support using either TXXX tags for ID3v2.3 or RVA2 tags for ID3V2.4. Should we close this patch as it’s unlikely that there’ll be support for replaygain on hwcodec?
I don’t believe it’s entirely unlikely. It’s certainly possible as the original patch shows (although I belive it might not be quite as fine-grained as the tags suggest, because of hardware limitations).