Rockbox

  • Status Closed
  • Percent Complete
    0%
  • Task Type Patches
  • Category
  • Assigned To No-one
  • Operating System
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by linusnielsen - 2004-07-12
Last edited by linusnielsen - 2004-07-24

FS#2266 - Safe poweroff

A proposal on how to implement a “safe” poweroff
function. Of you press OFF/STOP in the browser when no
music is playing, you will get a dialog saying “Press
OFF to shut off”. If you press OFF again, it will save
the settings, spin down the hard disk and then shut off.

   safe_poweroff.mod (138.7 KiB)
   safe_poweroff_fmrec.ajz (183.7 KiB)
   poweroff.diff (7.1 KiB)
   safe_poweroff_v2rec.ajz (183.7 KiB)
   safe_poweroff_rec.ajz (179.6 KiB)
Closed by  linusnielsen
2004-07-24 21:27
Reason for closing:  Accepted
bluechip commented on 2004-07-17 00:30

Just some feedback to show appreciation.

o If you do not press “off” a second time, the splash
screen is not removed

o Does not fade volume

o When you press off 2nd time, there is no notice … maybe “shutting down now” would be nice?

Project Manager
linusnielsen commented on 2004-07-19 09:50

New version.

Changes:

- “Shutting off…” text
- Mutes the MAS
- Refreshes the screen when cancelling
- Added a menu option, “Shut off”. This is now the only way
of shutting off the Player
- You can now shut off even if music is playing
- Saves the settings to disk, spinning up the disk if necessary

salokyn commented on 2004-07-19 10:34

[on REC V1]
Still a little refresh bug when a line is scrolling under
the confirmation message. Except this, it’s perfect :-)

trotso commented on 2004-07-19 15:01

Really nice one. Like it a lot.
But,
1. It would be logical if, when browsing through WPS (with ON), the first
press of OFF would just stop the playback, and then the shutdown procedure
activated (two presses). This way: {Not playing = two presses; Playing =
three presses}
2. Also, couldn’t we do without the confirmation when choosing to shutdown
from the menu? (Kind of “Don’t do the crime if you can’t do the time”… :^)
3. If there is an inverted scrolling bar under the dialog, the dialog still gets
obscured.

Project Manager
linusnielsen commented on 2004-07-20 05:54

New version:

- Stops the scrolling when the dialog is shown
- No dialog when shutting off from the menu
- OFF now stops the music if it’s playing, else displays the
dialog

salokyn commented on 2004-07-20 10:43

It seems ready to be added to Rockbox now !

trotso commented on 2004-07-20 21:41

Thanks for the excellent fixes,
but,
1. when playing, and OFF is pressed quickly three times, sometimes the disk
spins up immediately, which seems to cause one of the OFFs to get lost, and
thereby the unit can stay on even if one might think it’s off. (Thought there was
a keyboard buffer to take care of this.)
2. when DC is plugged in, the safe poweroff causes complete silence while
playing (at least on digital out) when it starts up again. (I know - who in his
right mind would want to power off the unit when it’s connected to DC? Maybe
this could reveal something missing in the startup code, though…)

Project Manager
linusnielsen commented on 2004-07-21 05:27

New version:

- Doesn’t mute the MAS if we can’t power off for real
- Doesn’t clear the button queue in the confirmation dialog

Project Manager
linusnielsen commented on 2004-07-24 21:14

New version:

- Doesn’t show the shutdown dialog if the charger is attached

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing