Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#2648 - text viewer button mods

Attached to Project: Rockbox
Opened by rubberglove (rubberglove) - Wednesday, 24 August 2005, 02:27 GMT+1
Last edited by Torne Wuff (torne) - Saturday, 20 March 2010, 22:16 GMT+1
Task Type Patches
Category
Status Closed
Assigned To No-one
Player Type
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

modified button assignment in text viewer slightly so that you have
to HOLD left/right to jump to the beginning/end of the file, instead of
simply pressing... this should avoid accidental jumping around.
   viewer.diff (2 KiB) 
 apps/plugins/viewer.c |   34 +++++++++++++++++++++++++++++++++-
 1 file changed, 33 insertions(+), 1 deletion(-)

This task depends upon

Closed by  Torne Wuff (torne)
Saturday, 20 March 2010, 22:16 GMT+1
Reason for closing:  Fixed
Additional comments about closing:  Implemented in r25262
Comment by rubberglove (rubberglove) - Thursday, 25 August 2005, 17:52 GMT+1

changed button mapping slightly so that (in wide mode) you must press
and hold left/right to jump to the beginning/end of the file, to prevent
accidental jumping around.
also added basic track skipping (previous and next track) for iriver
next=play+select
previous=play+stop
Comment by Victor Karpunin (kva) - Friday, 29 December 2006, 08:17 GMT+1
It's good patch for me. Because I sometimes click left/right buttons in narrow mode and it isn't comfortably to jump to the beginning/end of the file, when I read it. So I try to rebuild my own rockbox version with the patch. And I found some troubles with it. Really I'm not a programmer, C programmer but I corrected errors, I think so, and for me patch works. So if someone wants to use it, I upload it.
(application/octet-stream)    viewer.patch (1.7 KiB) 
 viewer.c |   35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

Comment by Victor Karpunin (kva) - Monday, 30 July 2007, 15:24 GMT+1
My last sync.
   viewer.patch (2.7 KiB) 
 apps/plugins/viewer.c |   59 ++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 59 insertions(+)

Comment by Philip Hansen (Philip Hansen) - Monday, 31 March 2008, 22:01 GMT+1
Has anyone made a patch that allows you to change pages by pressing the NEXT and PREV buttons, instead of scrolling? Sometimes I accidently touch the scroll pad and it's rather anoying.
Comment by Jonathan Gordon (jdgordon) - Thursday, 17 April 2008, 15:25 GMT+1
So, I was about to commit this but we need your full real name.. please add it in a comment so this can go in.
Comment by Victor Karpunin (kva) - Wednesday, 23 April 2008, 20:34 GMT+1
@Jonathan Gordon:
If you mean my real name, it's Victor Karpunin.
If you mean rubberglove, I don't know who is he :)
Comment by Torne Wuff (torne) - Saturday, 20 March 2010, 22:16 GMT+1
I have implemented this differently (it just remaps the buttons before entering the switch statement, which is less code), and it's committed in r25262.

The track skipping buttons are not implemented as the current version of the text viewer uses more button combinations for bookmarks and other new features, and there isn't room any more :)

Loading...