This is the bug/patch tracker for Rockbox. Click here for more information.
Quick links: Bugs · Patches · Rockbox frontpage
FS#2653 - added one-click-to-insert functionality in file tree
Attached to Project:
Rockbox
Opened by rubberglove (rubberglove) - Sunday, 28 August 2005, 02:59 GMT+2
Last edited by Bryan Childs (GodEater) - Thursday, 24 December 2009, 08:28 GMT+2
Opened by rubberglove (rubberglove) - Sunday, 28 August 2005, 02:59 GMT+2
Last edited by Bryan Childs (GodEater) - Thursday, 24 December 2009, 08:28 GMT+2
|
Detailsthat's it. for iriver (i think) click the joystick
(select) to insert the selected track/directory/playlist to the current playlist (or create a new one if none) seems to work, use with caution, enjoy. 
oneclick.diff
(3.2 KiB)
apps/onplay.c | 9 +++++++++ apps/onplay.h | 1 + apps/tree.c | 44 +++++++++++++++++++++++++++++++++++++------- 3 files changed, 47 insertions(+), 7 deletions(-)
oneclick_custom.difff
(7.1 KiB)
oneclick-custom-insert_rubbergloveMmmm.patch
(7.9 KiB)
apps/onplay.c | 22 ++++++++++++++++++++ apps/onplay.h | 1 apps/playlist_menu.c | 17 ++++++++++++++++ apps/settings.c | 1 apps/settings.h | 3 ++ apps/tree.c | 52 ++++++++++++++++++++++++++++++++++++++++++------- apps/tree.h | 2 + apps/lang/english.lang | 13 ++++++++++++ 8 files changed, 104 insertions(+), 7 deletions(-)
oneclick-custom_insert_rubbergloveMmmm.patch
(7.9 KiB)
apps/onplay.c | 22 ++++++++++++++++++++ apps/onplay.h | 1 apps/playlist_menu.c | 17 ++++++++++++++++ apps/settings.c | 2 - apps/settings.h | 3 ++ apps/tree.c | 52 ++++++++++++++++++++++++++++++++++++++++++------- apps/tree.h | 2 + apps/lang/english.lang | 13 ++++++++++++ 8 files changed, 104 insertions(+), 8 deletions(-) |
This task depends upon
Closed by Bryan Childs (GodEater)
Thursday, 24 December 2009, 08:28 GMT+2
Reason for closing: Rejected
Additional comments about closing: This is changing the basic behaviour of the select button in the file viewer, and is never likely to be accepted into the rockbox core.
Thursday, 24 December 2009, 08:28 GMT+2
Reason for closing: Rejected
Additional comments about closing: This is changing the basic behaviour of the select button in the file viewer, and is never likely to be accepted into the rockbox core.
an update that works with recent builds (2005-10-31) can be
found here: http://forums.rockbox.org/index.php?
action=dlattach;topic=1617.0;id=249
I hope the patch lasts until it finally find its way into the CVS ;)
First patch ever, so watch out. :)
Any chance to get an update for the new changes in the settings.c code?
Thanks a lot, Norbert
Still hoping this can be included in svn
Hope it works for you.
Also, there is no chance of commit as long as 1) this isnt ifdefed to only work for targets which have a spare button (i.e not ondio), 2) is changed to replace ACTION_STD_OK when a target has 2 buttons which can do that (iriver, sansa, ipod, you wold use right instead of SELECT), 3) add an enum for the various setting values, if(global_settings.click_insert==1) is nasty. 4) the stuff in playlist_menu.c (the option config) needs to be moved to settings_list.c (copy the CHOICE_SETTING() macro items).
-This patch causes SELECT not to work in the menus (have to use NEXT to choose menu items). It would be better if it did not affect the menus, only the file browser, in my opinion. I looked at the code a little, but it is beyond me. By the way, I am using a Gigabeat F.
-It would be nice if there were a "replace current playlist" option as well (similar to pressing ENTER while a track is selected from the file browser).
I've put a similar patch up at
FS#9873. consider contributing to it please.Here's what my settings.h.rej says:
***************
*** 429,435 ****
bool backlight_fade_in;
bool backlight_fade_out;
#endif
-
#ifdef HAVE_BACKLIGHT_BRIGHTNESS
int brightness;
#endif
--- 429,437 ----
bool backlight_fade_in;
bool backlight_fade_out;
#endif
+ int click_insert; /*setting for click behaviour in file tree:
+ 0:insert, 1:insert last,2:queue,
+ 3:queue last,4:insert shuffled*/
#ifdef HAVE_BACKLIGHT_BRIGHTNESS
int brightness;
#endif