FS#2767 - Screen scroll

Attached to Project: Rockbox
Opened by lshachar (lshachar) - Saturday, 19 November 2005, 02:24 GMT
Last edited by lshachar (lshachar) - Sunday, 22 January 2006, 02:12 GMT
Task Type Patches
Category LCD
Status Closed
Assigned To No-one
Operating System
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


horizontal scroll!

This patch binds on+left and on+right to scroll screen view
to the sides. this is very usefull when viewing a folder
with long artist name: you can simply scroll the view
to the right and see the filenames ends.
(iriver remote: volume up/down)

it was tested on a recorder, gmini and ondio simulators
and is running on my h120 player.

this patch does not build for the recorder, i've figured

it's kind of silly when it can affect only two lines


there are two new options in General settings ->
Display ->

Scrolling menu:

Screen scrolls out of view:
let you choose if you rather have lines slipping out of
when scrolling sideways, or stop the line from scrolling

when reaching it's end.

Screen scroll step size:
To set how much pixels are scrolled with a click.

the only thing that stops when right scrolling, is

letting the offset value go over 1000. that means if

keep holding on+right, you will increase the offset value

without effecting the view, and it will take you longer to

resume the original position. the solution would be to

out what's the longest item in the list, and using that

pixel number as a maximum on right scrolling.

There should be a different integer individualy kept

for file viewing and playlist viewing, so when you'r
back on

viewing the file list, it's in the same place. the next

phase would be to have a different assignments for every


(plugin and filetree uses the same list, and they are

the only ones that do not initialized in every use...

wierd results in plugins if filetree was scrolled...
and you

can scroll the menus as well, this should be all
solved, I'm

way to tierd to do this.)

furthermore, it might be a good idea to have every

folder have it's own saved offset configuration. that way,

when you'll enter a folder with long artist name, the

display will just go to the correct place without any

hassle. that is, of course, if you had scrolled it to the

desired place before. (maybe embedding the offset
integer in

the dircache? only in folders that you have changed the

setting? just a thought, anyhow.)

one last thing, if you set "screen scroll out of

to yes, and the selected item is starting to get out of

view, i've just made the item not scroll. scrolling
gave me

a lot of headaches and if this will be accepted we can
go on

to working the bugs out.

I hope this is made 'the right way' (I'm sure many of it

isn't.) and I hope that you might think it's a good patch

too! I simply love it now, especially the remote!

Liberman Shachar.
This task depends upon

Closed by  Daniel Stenberg (bagder)
Thursday, 23 March 2006, 22:52 GMT
Reason for closing:  Accepted
Additional comments about closing:  in CVS
Comment by lshachar (lshachar) - Thursday, 15 December 2005, 15:38 GMT

I've renamed some integers and functions for better
understanding. Also put the code in a better order and
disregarded any mistaken code changes.

However, there is some problem with building for the h300
series that i've recently came upon. I don't know exactly
what causes it, but it's somewhat because of the h100-remote
lcd driver. (If I disable the remote - it works.)
Comment by lshachar (lshachar) - Tuesday, 20 December 2005, 11:25 GMT

Fixed everything. now it compiles perfectly for h300. for
ipod's hold select button and scroll the keypad to activate.
Comment by Shachar (Lamed) - Thursday, 23 March 2006, 21:13 GMT
I've thought I could Kill my own 'tasks' on FS, especially when it's already in CVS.