Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#2809 - H1x0 or H3x0 select remote patch

Attached to Project: Rockbox
Opened by takka (tfact) - Wednesday, 07 December 2005, 02:46 GMT+2
Last edited by takka (tfact) - Monday, 23 January 2006, 16:11 GMT+2
Task Type Patches
Category Settings
Status Closed
Assigned To No-one
Player Type
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

set option
option->Generl Settings->Disply->Remote LCD Settings-
>Remote type

H100 or H300 LCD or H300 non LCD or OTHER

but I have H300.
You need rewrite key table.
   remote_type.patch (20.9 KiB) 
 rockbox/apps/gui/gwps-common.c    |   24 +++++++
 rockbox/apps/gui/gwps.c           |   22 ++++++
 rockbox/apps/gui/remote-flag.h    |   24 +++++++
 rockbox/apps/lang/english.lang    |   34 +++++++++
 rockbox/apps/settings.c           |    6 +
 rockbox/apps/settings.h           |    1 
 rockbox/apps/settings_menu.c      |   14 ++++
 rockbox/firmware/drivers/button.c |  130 +++++++++++++++++++++++---------------
 rockbox/firmware/export/button.h  |   10 ++
 rockbox/apps/tree.c               |   20 +++++
 rockbox/apps/tree.h               |    3 
 rockbox/apps/menu.c               |   20 +++++
 rockbox/apps/menu.h               |    6 +
 13 files changed, 263 insertions(+), 51 deletions(-)

This task depends upon

Closed by  Nils Wallménius (nls)
Friday, 03 November 2006, 09:19 GMT+2
Reason for closing:  Out of Date
Additional comments about closing:  Remotes for the iriver hxxx are automatically detected an hence this patch is no longer needed.
Comment by takka (tfact) - Wednesday, 07 December 2005, 21:08 GMT+2

It wrote and it made a mistake.
I have 'NOT' H300
Comment by takka (tfact) - Monday, 12 December 2005, 06:15 GMT+2

H3x0 Standard remote control can have been used.
Comment by takka (tfact) - Thursday, 15 December 2005, 02:23 GMT+2

bug fix
Comment by Anonymous Submitter - Thursday, 15 December 2005, 22:44 GMT+2

Thanks for the patch! I have 2 questions:

I couldn't get to the menu with the H300 LCD Remote, is it
possible?

why don't you set the H300 Remote arrow keys
(up,down,left,right) to operate as they on the main unit? I
think it's more convenient.
Idan
Comment by takka (tfact) - Friday, 16 December 2005, 03:27 GMT+2

bug fix
Comment by takka (tfact) - Friday, 16 December 2005, 03:30 GMT+2

It corresponded only at the mode
It was made to correspond to the file tree mode this time
Please use tree.patch

It has not corresponded to config mode yet.
Comment by takka (tfact) - Friday, 16 December 2005, 03:34 GMT+2

It corresponded only at the 'WPS' mode
It was made to correspond to the file tree mode this time
Please use tree.patch

It has not corresponded to config mode yet.
Comment by perplexity (bkc1974) - Saturday, 17 December 2005, 08:51 GMT+2

My H340 with Non-LCD remote never deviates from 0xFF for
ADC_REMOTE, no matter what combination of buttons I try.
With or without the remote plugged in.
With the remote plugged in it _always_ shows as hold enabled
on the remote. I have tried selecting all the available
remote types (but of course H300_non_LCD is the one I try to
use)

Enough to say the remote does not work :)
In fact, the only thing it does do is the play button on the
remote toggles GPIO1_READ 0x40. (reads 0xXXXXXX74 unplugged
or plugged and 0xXXXXXX34 with play pressed)
Comment by takka (tfact) - Saturday, 17 December 2005, 19:28 GMT+2

H300 NON LCD hold disable
Comment by takka (tfact) - Saturday, 17 December 2005, 19:31 GMT+2

bug fix
Comment by Anonymous Submitter - Sunday, 18 December 2005, 18:01 GMT+2

H300 LCD Remote:
in tree view, can you replace the keys:
vol up <-> right(forward)
vol down <-> left(backward)
so it will be like the main navi buttons ?

thanks,
Idan
Comment by takka (tfact) - Monday, 19 December 2005, 14:57 GMT+2

use 'tree.patch'

replace rc keys
vol up <-> right(forward)
vol down <-> left(backward)
Comment by Anonymous Submitter - Wednesday, 21 December 2005, 09:17 GMT+2

h340 with non-lcd remote and both patches applied :

Well, now the hold switch does not work. (expected)

The vol+/- buttons change the track playing, and the <<|>>
buttons change the volume :)

But at least it *does* something :)
Comment by perplexity (bkc1974) - Wednesday, 21 December 2005, 09:25 GMT+2

Hrm... forgot to log in below :)

Ok.. Now the hold is disabled my ADC_REMOTE values change
properly. Here are the ADC values for my h300-non-lcd remote

Idle : 0xFF (Unplugged or no button pressed)
Vol + : 0xE4
Vol - : 0xC8
<<| : 0x33 (skip back)
|>> : 0x18 (skip forward)
HOLD : 0x00
Comment by perplexity (bkc1974) - Wednesday, 21 December 2005, 19:05 GMT+2

Hrm... forgot to log in below :)

Ok.. Now the hold is disabled my ADC_REMOTE values change
properly. Here are the ADC values for my h300-non-lcd remote

Idle : 0xFF (Unplugged or no button pressed)
Vol + : 0xE4
Vol - : 0xC8
<<| : 0x33 (skip back)
|>> : 0x18 (skip forward)
HOLD : 0x00
Comment by perplexity (bkc1974) - Wednesday, 21 December 2005, 20:35 GMT+2

Revised version of this patch with the tree.patch rolled in,
tested and working on my h340 with non-lcd-remote

https://sourceforge.net/tracker/index.php?func=detail&aid=1387447&group_id=44306&atid=439120

I would have just attached it here, but I can't seem to
figure out how to do that.
Comment by takka (tfact) - Wednesday, 21 December 2005, 23:49 GMT+2

bug fix
Comment by takka (tfact) - Wednesday, 21 December 2005, 23:50 GMT+2

bug fix
Comment by takka (tfact) - Monday, 26 December 2005, 15:26 GMT+2

bug fix & marge patch

'thanks bkc1974'
Comment by takka (tfact) - Monday, 23 January 2006, 16:11 GMT+2

for 1/23 CVS

Loading...