Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#2885 - Ignore "the" in alphabetic dir sort

Attached to Project: Rockbox
Opened by Anonymous Submitter - Thursday, 05 January 2006, 18:04 GMT+2
Last edited by Rani Hod (RaeNye) - Monday, 18 September 2006, 18:48 GMT+2
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Private No

Details

Ignores "The" in the beginning of directory/file names
when alphabetically sorting. Also skips exactly one
trailing whitespace if present.

bk
mutualaid (at) gmail.com
   the-sorting.patch (2.3 KiB) 
 filetree.c |   42 ++++++++++++++++++++++++++++++++++++++----
 1 file changed, 38 insertions(+), 4 deletions(-)

This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Thursday, 21 December 2006, 14:30 GMT+2
Reason for closing:  Rejected
Additional comments about closing:  general consensus in IRC is that this adds nothing which couldn\'t be done by renaming your files.
Comment by Anonymous Submitter - Thursday, 05 January 2006, 21:55 GMT+2

Thanks for the patch! does this add an option to turn this
feature on/off? if not, can this option be added?

saa[b_r]ider
Comment by Anonymous Submitter - Friday, 06 January 2006, 00:37 GMT+2

No, it doesn't add a config option. I would consider this to
be config option bloat; either Rockbox does a "smart sort"
disregarding 'the' or it doesn't, there's little need for
yet another config item.

I *would* like to make it multi-lingual but I have no idea
how Rockbox localization works, or even if there is the
necessary info available for all languages.
Comment by bk01 (bk01) - Wednesday, 11 January 2006, 00:36 GMT+2

Latest version of this patch is available here:
http://forums.rockbox.org/index.php?topic=2272.msg16018#msg16018
Comment by Leo Davidson (Nudel) - Sunday, 12 March 2006, 10:20 GMT+2
Maybe the list should be configurable? Initially I thought maybe as part of the language file but I think it would be better as a separate config file (or string in the main config file) because I imagine people may want to mix prefixes from several languages together.

e.g. In my file manager I can set this as my ignore prefix:

"The |A "

A config file saves you having to think of all the prefixes for every langauge in advance, and means people can include/exclude them to their taste. e.g. Some people may find it weird that "A" is ignored but still want "The" ignored. Of course, having a good default config file in CVS is still important so that people are not forced to configure it, but being able to configure if desired is a plus.
Comment by Ben Keroack (bk) - Tuesday, 14 March 2006, 17:27 GMT+2
I agree it should be localized somehow, but I think it should be integrated with the existing localization system if possible. There needs to be an item in each language specifying that language's version of "the" (possibly also "A"). I have no idea if that's already provided or if not what it would take to provide it.

If that isn't feasible than an additional config item could be added, but then a parser for it would need to added (because it would be a string with the different ignore tokens separated by delimiters) and probably a GUI menu item and all these would complicate the patch significantly.
Comment by Ketil W Aanensen (kwaanens) - Tuesday, 19 September 2006, 00:21 GMT+2
In order to make such a feature really valuable, it would be extremely cool if I make my player do this:
- Ignore "The" always (except for The The which could make some confusion)
Ignore "Billy" in "Billy Bragg" (i.e. an artists' name), but not in "Billy Talent" which is a band name.
Comment by Ketil W Aanensen (kwaanens) - Tuesday, 19 September 2006, 00:28 GMT+2
By the way:
When you say "Ignores "The" in the beginning of directory/file names when alphabetically sorting. Also skips exactly one trailing whitespace if present."
Does that mean that "Therapy" will be sorted on "r"? I assuming no, of course.
Comment by Ben Keroack (bk) - Thursday, 21 September 2006, 01:21 GMT+2
No, "Therapy" would be sorted normally in the last patch (which is available in the forum thread).

Your suggestions would be addressed if this was implemented as a custom list of 'ignorable' strings (that would fix the localization issue too). However it's not possible for the sort code to distinguish between "Billy Bragg" and "Billy Talent", the string Billy is identical in both and it has no way of knowing that one should be ignored and the other should not.
Comment by Christoph Päper (crissov) - Friday, 22 September 2006, 11:28 GMT+2
Well, it would be able to sort "Billy" correctly, if it honoured the relevant tag, see http://www.rockbox.org/tracker/task/5923
Comment by Keith Barnett (captain_cornflake) - Wednesday, 08 November 2006, 13:46 GMT+2
Does this also apply when browsing the tag cache, or just when browsing the file system?
Comment by Ben Keroack (bk) - Thursday, 09 November 2006, 00:43 GMT+2
Anything that uses the qsort function will be affected, I assume this includes TagCache but I don't know that for sure.
Comment by Max Weninger (maxwen) - Sunday, 12 November 2006, 15:56 GMT+2
No tagcache has a different compare function.

The attached patch works both in file view and tagcache and also
adds a config option to turn it on and off.

Have fun

   ignore-the.patch (6.5 KiB) 
 filetree.c        |   42 ++++++++++++++++++++++++++++++++++++++----
 lang/english.lang |   14 ++++++++++++++
 settings.c        |    1 +
 settings.h        |    1 +
 settings_menu.c   |    6 ++++++
 tagcache.c        |   28 +++++++++++++++++++++++++++-
 6 files changed, 87 insertions(+), 5 deletions(-)

Comment by Joe Termini (joetermini) - Thursday, 16 November 2006, 22:09 GMT+2
hunk error... you need to resync
Comment by Max Weninger (maxwen) - Tuesday, 28 November 2006, 00:25 GMT+2
What "hunk error"
It applies cleanly against CVS from 20061120-2230
Comment by Brock Norman (mightybrick) - Thursday, 07 December 2006, 23:08 GMT+2
I just tried applying to CVS from 20061207-1946 and get a hunk error:
"patching file apps/filetree.c
patching file apps/tagcache.c
hunk #1 succeeded at 1636 (offest 20 lines).
hunk #2 FAILED at 1674."
All other hunks succeed.
Comment by Andrei (andryou) - Wednesday, 13 December 2006, 00:12 GMT+2
Fixed hunk error reported by Brock
(application/octet-stream)    ignore-the.patch (6.3 KiB) 
 filetree.c        |   42 ++++++++++++++++++++++++++++++++++++++----
 lang/english.lang |   14 ++++++++++++++
 settings.c        |    1 +
 settings.h        |    1 +
 settings_menu.c   |    6 ++++++
 tagcache.c        |   28 +++++++++++++++++++++++++++-
 6 files changed, 87 insertions(+), 5 deletions(-)

Comment by Max Weninger (maxwen) - Wednesday, 13 December 2006, 01:31 GMT+2
Added config option to enable/disable the "ignoring"
for id3 view and file view separately

Synced against CVS from today
   ignore-the.patch (8.2 KiB) 
 filetree.c        |   46 ++++++++++++++++++++++++++++++++---
 lang/english.lang |   70 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
 settings.c        |    7 +++++
 settings.h        |    5 +++
 settings_menu.c   |   24 ++++++++++++++++++
 tagcache.c        |   28 ++++++++++++++++++++-
 6 files changed, 175 insertions(+), 5 deletions(-)

Comment by Brock Norman (mightybrick) - Wednesday, 13 December 2006, 06:01 GMT+2
I just tried applying against today's CVS (20061213-0455), and I get the same hunk failure message as before. ???
Comment by Max Weninger (maxwen) - Wednesday, 13 December 2006, 11:49 GMT+2
Can you please try patch -I (ignore whitespaces)
Maybe I have some wrong tabs instead of spaces in
this file
Comment by Brock Norman (mightybrick) - Wednesday, 13 December 2006, 18:03 GMT+2
Sorry. It works now. I had issues saving the file correctly. It was a dumb mistake by me. Thanks!

Loading...