Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#2994 - Scrolling Margins for new CVS

Attached to Project: Rockbox
Opened by takka (tfact) - Tuesday, 07 February 2006, 07:19 GMT+2
Last edited by Matthias Mohr (aka Massa) (mmohr) - Sunday, 02 April 2006, 20:04 GMT+2
Task Type Patches
Category Themes
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

The patch adds the possibility to restrict the width of a (scrolling) line.
It enables you to position the scroll text inside the line and give him a
starting and ending position.
It extents the %s WPS tag to the following:
%s%m|x1|x2|
where x1 is the x-position where the line text starts and x2 is the
ending x-position of the scroll text (actually, when I look at the
code, it should also work for nonscrolling text...)
Only one margin is allowed per line.

BTW, I assume this patch will never find it's way into the CVS.
The devs plan something more generous, called "viewports".
The plan is to include it in v3.1 - regarding the release plan it
will be somewhere between now and (latest) November 2006.

Until the viewports find it's way into CVS this patch here seems
to be useful for a lot of people...
(and it is also the base for other patches)

You may find the patch compatible to the current CVS always
at the end of the comments to this task...
This task depends upon

Closed by  Ben Basha (paprica)
Monday, 03 April 2006, 14:36 GMT+2
Reason for closing:  Duplicate
Additional comments about closing:  we are returning to the orginal task
http://www.rockbox.org/tracker/task/2954
Comment by Matthias Mohr (aka Massa) (mmohr) - Saturday, 11 March 2006, 21:58 GMT+2
Here is the patch for today's CVS (20060311)

Hopefully the changed patch will work until it finally find it's way into the CVS ;)
(application/octet-stream)    scroll-margins_20060311.patch (35.9 KiB) 
 apps/bookmark.c                    |   12 ++++-----
 apps/debug_menu.c                  |   28 +++++++++++-----------
 apps/gui/gwps-common.c             |   41 +++++++++++++++++++++++++++-----
 apps/gui/gwps.c                    |    7 ++---
 apps/gui/list.c                    |    2 -
 apps/onplay.c                      |    4 +--
 apps/playlist.c                    |    8 +++---
 apps/plugin.c                      |   12 ++++-----
 apps/recorder/recording.c          |    4 +--
 apps/screen_access.c               |    6 +++-
 apps/screen_access.h               |   11 ++++----
 apps/screens.c                     |    6 ++--
 apps/sleeptimer.c                  |    4 +--
 firmware/drivers/lcd-16bit.c       |   46 ++++++++++++++++++++++++-------------
 firmware/drivers/lcd-h100-remote.c |   25 ++++++++++++--------
 firmware/drivers/lcd-h100.c        |   46 +++++++++++++++++++++++++------------
 firmware/drivers/lcd-recorder.c    |   44 ++++++++++++++++++++++++-----------
 firmware/export/lcd-remote.h       |    5 ++--
 firmware/export/lcd.h              |    7 ++++-
 19 files changed, 204 insertions(+), 114 deletions(-)

Comment by Matthias Mohr (aka Massa) (mmohr) - Friday, 24 March 2006, 23:26 GMT+2
Here is another sync to today's CVS (2006-03-24)

Although it seems it'll never find it's way into CVS...
(application/octet-stream)    scroll-margins_20060324.patch (37 KiB) 
 apps/bookmark.c                    |   12 ++++-----
 apps/debug_menu.c                  |   28 +++++++++++-----------
 apps/gui/gwps-common.c             |   41 +++++++++++++++++++++++++++-----
 apps/gui/gwps.c                    |    7 ++---
 apps/gui/list.c                    |    2 -
 apps/onplay.c                      |    4 +--
 apps/playlist.c                    |    8 +++---
 apps/plugin.c                      |   12 ++++-----
 apps/recorder/recording.c          |    4 +--
 apps/screen_access.c               |    6 +++-
 apps/screen_access.h               |   11 ++++----
 apps/screens.c                     |    6 ++--
 apps/sound_menu.c                  |    6 ++--
 firmware/drivers/lcd-16bit.c       |   46 ++++++++++++++++++++++++-------------
 firmware/drivers/lcd-2bit-horz.c   |   14 ++++++++---
 firmware/drivers/lcd-h100-remote.c |   25 ++++++++++++--------
 firmware/drivers/lcd-h100.c        |   46 +++++++++++++++++++++++++------------
 firmware/drivers/lcd-recorder.c    |   44 ++++++++++++++++++++++++-----------
 firmware/export/lcd-remote.h       |    5 ++--
 firmware/export/lcd.h              |    7 ++++-
 20 files changed, 215 insertions(+), 119 deletions(-)

Comment by Rob (biffhero) - Saturday, 25 March 2006, 06:42 GMT+2
scroll-margins_20060324.patch applied to the cvs download I have from 2006-03-24_22:02 However, it does not build.

CC debug_menu.c
debug_menu.c: In function `dbg_ports':
debug_menu.c:1042: error: too few arguments to function `lcd_setmargins'
make[1]: *** [/home/rob/ipod-linux/rockbox/cvs/src/rockbox-bleeding/build/apps/debug_menu.o] Error 1
make: *** [all] Error 2

I looked at your patch, and changed line 1042 to be -> lcd_setmargins(0, LCD_WIDTH, 0);

And it at least builds now. :-)

Hope this gets into CVS soon!
Comment by Rob (biffhero) - Saturday, 25 March 2006, 07:36 GMT+2
It built just fine, and my iPod 5G runs ok. I don't know, however, what this patch is supposed to do, so I can't tell you if I have tested exactly this code.
Comment by Alexander Bondar (davinci) - Saturday, 25 March 2006, 11:14 GMT+2
This patch will never get into CVS, so the developers. They want to make something like containers which can get positioned at any position on the display. Sorry, I don't know the name of it anymore.
But as long there is no alternative for the scroll margins patch I will use it.
Comment by Matthias Mohr (aka Massa) (mmohr) - Sunday, 26 March 2006, 00:48 GMT+2
Rob, you were right. It seems I missed that line - and a few others ;)
I added an updated patch which also fixes some small bugs I found.

I also updated the description of the patch above...

And yes, I also doubt it will ever be put into CVS.
The devs plan something more generous, called "viewports".
The plan is to include it in v3.1 - regarding the release plan it'll
be (latest) November 2006.

So until then this patch here is needed for a lot of people...
(and is also the base for other patches)
(application/octet-stream)    scroll-margins_20060326.patch (39.2 KiB) 
 apps/bookmark.c                    |   12 ++++----
 apps/debug_menu.c                  |   30 +++++++++++-----------
 apps/gui/gwps-common.c             |   50 +++++++++++++++++++++++++++++++------
 apps/gui/gwps.c                    |    7 ++---
 apps/gui/list.c                    |    2 -
 apps/logfdisp.c                    |    2 -
 apps/onplay.c                      |    4 +-
 apps/pcm_recording.c               |    2 -
 apps/playlist.c                    |    8 ++---
 apps/plugin.c                      |   12 ++++----
 apps/recorder/recording.c          |    4 +-
 apps/screen_access.c               |    6 ++--
 apps/screen_access.h               |   11 ++++----
 apps/screens.c                     |    6 ++--
 apps/sound_menu.c                  |   11 ++++----
 firmware/drivers/lcd-16bit.c       |   44 ++++++++++++++++++++++----------
 firmware/drivers/lcd-2bit-horz.c   |   14 +++++++---
 firmware/drivers/lcd-h100-remote.c |   25 +++++++++++-------
 firmware/drivers/lcd-h100.c        |   46 +++++++++++++++++++++++-----------
 firmware/drivers/lcd-recorder.c    |   44 ++++++++++++++++++++++----------
 firmware/export/lcd-remote.h       |    5 ++-
 firmware/export/lcd.h              |    7 +++--
 firmware/logf.c                    |    2 -
 23 files changed, 230 insertions(+), 124 deletions(-)

Comment by Nicolas Pennequin (nicolas_p) - Wednesday, 29 March 2006, 16:58 GMT+2
Synched with current CVS (2006-03-29)
Comment by Nicolas Pennequin (nicolas_p) - Wednesday, 29 March 2006, 17:49 GMT+2
Fixed a small problem in the previous patch
(application/octet-stream)    scroll_margins_20060329.patch (39.4 KiB) 
 apps/bookmark.c                    |   12 ++++----
 apps/debug_menu.c                  |   32 +++++++++++------------
 apps/gui/gwps-common.c             |   50 +++++++++++++++++++++++++++++++------
 apps/gui/gwps.c                    |    7 ++---
 apps/gui/list.c                    |    2 -
 apps/logfdisp.c                    |    2 -
 apps/onplay.c                      |    4 +-
 apps/pcm_recording.c               |    2 -
 apps/playlist.c                    |    8 ++---
 apps/plugin.c                      |   12 ++++----
 apps/recorder/recording.c          |    4 +-
 apps/screen_access.c               |    6 ++--
 apps/screen_access.h               |   11 ++++----
 apps/screens.c                     |    6 ++--
 apps/sound_menu.c                  |   11 ++++----
 firmware/drivers/lcd-16bit.c       |   44 ++++++++++++++++++++++----------
 firmware/drivers/lcd-2bit-horz.c   |   14 +++++++---
 firmware/drivers/lcd-h100-remote.c |   25 +++++++++++-------
 firmware/drivers/lcd-h100.c        |   46 +++++++++++++++++++++++-----------
 firmware/drivers/lcd-recorder.c    |   44 ++++++++++++++++++++++----------
 firmware/export/lcd-remote.h       |    5 ++-
 firmware/export/lcd.h              |    7 +++--
 firmware/logf.c                    |    2 -
 23 files changed, 231 insertions(+), 125 deletions(-)

Comment by Matthias Mohr (aka Massa) (mmohr) - Sunday, 02 April 2006, 20:00 GMT+2
Here is another sync to the current CVS (2006-04-02)
(application/octet-stream)    scroll-margins_20060402.patch (40.9 KiB) 
 apps/bookmark.c                    |   12 ++++----
 apps/debug_menu.c                  |   32 +++++++++++------------
 apps/gui/gwps-common.c             |   50 +++++++++++++++++++++++++++++++------
 apps/gui/gwps.c                    |    7 ++---
 apps/gui/list.c                    |    2 -
 apps/logfdisp.c                    |    2 -
 apps/onplay.c                      |    4 +-
 apps/pcm_recording.c               |    2 -
 apps/playlist.c                    |    8 ++---
 apps/plugin.c                      |   12 ++++----
 apps/recorder/recording.c          |    4 +-
 apps/screen_access.c               |    6 ++--
 apps/screen_access.h               |   11 ++++----
 apps/screens.c                     |   24 +++++++++--------
 apps/sound_menu.c                  |   11 ++++----
 firmware/drivers/lcd-16bit.c       |   44 ++++++++++++++++++++++----------
 firmware/drivers/lcd-2bit-horz.c   |   14 +++++++---
 firmware/drivers/lcd-h100-remote.c |   25 +++++++++++-------
 firmware/drivers/lcd-h100.c        |   46 +++++++++++++++++++++++-----------
 firmware/drivers/lcd-recorder.c    |   44 ++++++++++++++++++++++----------
 firmware/export/lcd-remote.h       |    5 ++-
 firmware/export/lcd.h              |    7 +++--
 firmware/logf.c                    |    2 -
 23 files changed, 241 insertions(+), 133 deletions(-)

Loading...