Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#3037 - Gif Viewer

Attached to Project: Rockbox
Opened by Anonymous Submitter - Friday, 17 February 2006, 18:23 GMT+2
Last edited by Dominik Riebeling (bluebrother) - Saturday, 04 June 2011, 22:43 GMT+2
Task Type Patches
Category Plugins
Status Closed
Assigned To No-one
Player Type
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

i've made a gif viewer called viewbox
it would be great if someone will be nice enough
to go over it and fix it for the H300 target cause
it works only on the h300 sim and apperantly on the
ipod too...
This task depends upon

Closed by  Dominik Riebeling (bluebrother)
Saturday, 04 June 2011, 22:43 GMT+2
Reason for closing:  Out of Date
Additional comments about closing:  image viewers are now consolidated in the imageviewer plugin
Comment by Geoff Stokes (iwantanimac) - Thursday, 02 November 2006, 16:40 GMT+2
I like this. It could use some wotk, but it's a very good feature Rockbox should have had for a while.

Ill try it out and see if it still works later, then if not ill try to get it up to speed, and include some new keymaps, too.
Comment by Pascal Briehl (ColdSphinX) - Thursday, 22 March 2007, 13:02 GMT+2
I'm looking for an c written gif-lib to port, or can any coredev have a look?
Currently I did only fixed errors and warnings, removed unnecessary code and renamed it to gifview.
   gifview.zip (118.6 KiB)
Comment by Pascal Briehl (ColdSphinX) - Friday, 30 March 2007, 10:29 GMT+2
Now in my holidays I hope i get it to work.
(application/octet-stream)    gifview.c (19.9 KiB)
Comment by Eli Sherer (elisherer) - Monday, 23 April 2007, 17:05 GMT+2
is there any progress?
Comment by Pascal Briehl (ColdSphinX) - Monday, 23 April 2007, 17:18 GMT+2
No, sorry I'm learning for my exams :(
You can work with the latest code above.
Comment by Eli Sherer (elisherer) - Monday, 23 April 2007, 19:08 GMT+2
I think even though you think that the BMP viewer is useless because rockpaint opens BMP
already, I think we need a more developed viewer for BMP (zoom and stuff)
and leave the editing for rockpaint through the "Open With..." option...
Comment by Eli Sherer (elisherer) - Monday, 23 April 2007, 19:09 GMT+2
in the end it's the same code
which i've written...
(i've written both rockpaint and viewbox)
Comment by Pascal Briehl (ColdSphinX) - Monday, 23 April 2007, 21:02 GMT+2
I just thought there is no need for a third bmpviewer and removed the bmpviewer from the gifviewer-code, because there are already two.
Comment by Paul Kovack (chibitactician) - Tuesday, 16 December 2008, 16:48 GMT+2
where do the .c files go?
Comment by Marc Guay (Marc_Guay) - Tuesday, 16 December 2008, 16:53 GMT+2
Paul: Patches are modifications to the source code. If you wish to test them, you must build your own binary using a compiler. Please research this in the wiki and elsewhere.
Comment by Gman (Thecoolgman) - Tuesday, 31 March 2009, 08:01 GMT+2
Can someone update this file?
Comment by jeff pruet (jeffp) - Wednesday, 31 March 2010, 19:22 GMT+2
i second Gman's comment. we need a gif viewer!
Comment by Gman (Thecoolgman) - Wednesday, 31 March 2010, 21:49 GMT+2
Heh, Only took one year for someone to agree with me.
Comment by Rui Araújo (Akur) - Monday, 19 July 2010, 21:16 GMT+2
This compiles and runs with svn revision 27497.

Tested in Sansa Fuze V2 simulator.
Same file as above but synced..
   gifview.diff (21.4 KiB)
 apps/plugins/CATEGORIES |    1 
 apps/plugins/SOURCES    |    1 
 apps/plugins/gifview.c  |  728 ++++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 730 insertions(+)

Comment by Rui Araújo (Akur) - Tuesday, 20 July 2010, 14:41 GMT+2
A few things that I forgot to warn...

The patch above was tested only with very simple gif. Do NOT try animated gifs as it will not work. Besides this has no support for greyscale players.
You use it on a simulator only.
Comment by Robert Menes (RMenes379) - Wednesday, 29 December 2010, 19:27 GMT+2
This patch needs a lot of new keymaps to work on new targets, and should probably be incorporated into the new universal image viewer
plugin that we have in SVN now. It's a great plugin, otherwise.
Comment by jer (redblade8) - Wednesday, 26 January 2011, 21:23 GMT+2
I hope one day it will also support animated .gif's as well =P there are just so many it shouldn't be an omission ^^

Loading...