Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#4719 - mandelbrot clear button queue after calculation and keep iter setting after zooming

Attached to Project: Rockbox
Opened by Mikael Magnusson (mikaelh) - Friday, 24 February 2006, 09:41 GMT+2
Last edited by Teruaki Kawashima (teru) - Tuesday, 19 January 2010, 08:06 GMT+2
Task Type Patches
Category Applications
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Currently mandelbrot will keep itself busy for a while if you press zoom too many times, so clear the button queue after finishing a calculation. Also, after zooming the iter variable is reset, which is annoying if you lower it to zoom in somewhere faster.
   rockbox-mandelbrot-clear-queue-and-keep-max_iter.... (1.1 KiB) 
 apps/plugins/mandelbrot.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

This task depends upon

Closed by  Teruaki Kawashima (teru)
Tuesday, 19 January 2010, 08:06 GMT+2
Reason for closing:  Out of Date
Additional comments about closing:  superseded by  FS#10911  which enables to interrupt calculation.
Comment by Johannes Linke (Jaykay) - Saturday, 20 December 2008, 12:38 GMT+2
i suggest committing. it works well and gevaerts said it can be included but didnt do it because of the 3.1-freeze
Comment by Paul Louden (Llorean) - Saturday, 10 January 2009, 17:58 GMT+2
This seems like it could be very annoying if you wanted to zoom in 5 levels, and you pressed it five times quickly, but it cleared so you lose some of them. Is it possibly to lose button presses with this patch?
Comment by Dominik Riebeling (bluebrother) - Saturday, 10 January 2009, 18:08 GMT+2
if you want to zoom in 5 levels wouldn't it be better to abort the first 4 calculations (i.e. abort the calculation once the zoom level is changed again) and restart calculating from the top?
Comment by Johannes Linke (Jaykay) - Saturday, 10 January 2009, 18:12 GMT+2
yes. if you press the zoom-key one time and then four times while calculating, the four key presses are ignored.

i guess it can be closed. its not wanted and the suggested improvements will be done in a few years or never.
Comment by Thomas Martitz (kugel.) - Thursday, 05 February 2009, 16:24 GMT+2
I think it should be committed. Loosing button presses during operations which lead to unresponsiveness isn't annyoing, but safer and should be the common case.
Comment by Paul Louden (Llorean) - Thursday, 05 February 2009, 16:31 GMT+2
I 100% disagree. I consider being able to queue "zoom" actions a feature and think having to press the button several more times than necessary because it's intentionally ignoring presses a significant problem.

Fix is as bluebrother suggested possibly, but don't ignore button presses. If someone presses zoom 19 times you should be on the 20th level of zoom, not some unpredictable level depending entirely on how quickly/slowly they pressed it.
Comment by Dominik Riebeling (bluebrother) - Saturday, 14 February 2009, 22:12 GMT+2
If you consider it as a problem that you have to wait for all calculations you queued to finish add a dedicated abort button. I still think that zoom levels should be able to get skipped. Dropping the button presses is still the worst solution from my point of view.
Comment by Johannes Linke (Jaykay) - Sunday, 15 February 2009, 14:45 GMT+2
i suggest closing, since bluebrother and llorean think its the worst solution...
Comment by Johannes Linke (Jaykay) - Sunday, 15 February 2009, 14:48 GMT+2
imo the abort button plus the first suggestion by bluebrother is the best solution.

Loading...