Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#4761 - Hold Switch Pause Games

Attached to Project: Rockbox
Opened by Shachar (Lamed) - Friday, 03 March 2006, 18:44 GMT+2
Task Type Feature Requests
Category Plugins
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

I've Figured what a great Idea it was, If putting the player on HOLD will automatically pause plugins such as games.
It's a tricky combination to firstly pause the game and then lock the player as it is today, and futhermore, it could be a consistent key combination in every plugin. (at least for players that has a hold switch :)
This task depends upon

Closed by  Björn Stenberg (zagor)
Sunday, 30 July 2006, 09:16 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Closing all feature requests.
Comment by Linus Nielsen Feltzing (linusnielsen) - Saturday, 04 March 2006, 12:58 GMT+2
This is a great idea, I must say. There is one minor quirk, though, and that is that the Hold switch controls the display mode in Rockboy on the H100. I guess we can easily change that.
Comment by Lukas Sabota (punkrockguy318) - Sunday, 16 April 2006, 05:27 GMT+2
Added this behavior in the following three patches for jewels, snake, and snake2.
http://www.rockbox.org/tracker/task/5139
http://www.rockbox.org/tracker/task/5140
http://www.rockbox.org/tracker/task/5141
Comment by Lukas Sabota (punkrockguy318) - Sunday, 16 April 2006, 05:50 GMT+2
I've also written patches for brick and spacerocks :)
http://www.rockbox.org/tracker/task/5142
http://www.rockbox.org/tracker/task/5143
Comment by Shachar (Lamed) - Sunday, 16 April 2006, 23:16 GMT+2
dang! I was just starting to work on it myself...

please state as soon as possible what other plugins are you going to port so we won't end up doing the same work :)
Comment by Lukas Sabota (punkrockguy318) - Monday, 17 April 2006, 00:03 GMT+2
Well what plugins are left that need to be ported? The only other game that actually needs to be paused is wormlet. Are there any others?
Comment by Lukas Sabota (punkrockguy318) - Monday, 17 April 2006, 00:18 GMT+2
I'm not going to get a chance to do too much coding for a while, so go ahead and patch away at the plugins that could still use the functionality.
Comment by Shachar (Lamed) - Wednesday, 19 April 2006, 16:49 GMT+2
I'll probably have those done the next time i'm home, in about 11 days. hope this makes it into cvs.
Comment by Shachar (Lamed) - Monday, 01 May 2006, 12:50 GMT+2
here's a patch bundle for: brickmania, bubbles, snake, snake2, spacerocks, wormlet, xobox, pacbox.

The concept was to change the game code as little as I could, so on all games that had a pause option, we just change the button integer to pause button;
It is less likely to cause an error like this and no code duplication is caused.

other plugins that might use this patch: pong, rockblox.
   holdswitch_bundle8.patch (4.6 KiB) 
 brickmania.c    |    6 ++++++
 bubbles.c       |    6 ++++++
 snake.c         |    6 ++++++
 snake2.c        |    6 ++++++
 spacerocks.c    |    6 ++++++
 wormlet.c       |    6 ++++++
 xobox.c         |    8 ++++++++
 pacbox/pacbox.c |    5 +++++
 8 files changed, 49 insertions(+)

Comment by Shachar (Lamed) - Sunday, 21 May 2006, 11:23 GMT+2
Will someone Due this to 3.0?

Loading...