Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#4796 - Display current dir while browsing files

Attached to Project: Rockbox
Opened by Mark Arigo (lowlight) - Tuesday, 07 March 2006, 20:02 GMT+1
Task Type Patches
Category
Status Closed
Assigned To No-one
Player type All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch adds "titles" to the gui list widget. It allows for setting a title/icon to display at the top of the list.

Currently, I'm using this feature to show the current directory (except the root dir) while browsing files. See http://forums.rockbox.org/index.php?topic=2876.0 for an example. To enable this, there's a menu option in General Settings -> File View -> Show Current Dir.

Note: Scrolling the title was a problem because line scrolling depends on the screen xmargin which needs to be different for the title line versus the rest of the items. I've included a work around for ONLY the H100 (lcd-h100.c and lcd-h100-remote.c) and I haven't observed any fowl behavior. The changes should be the same for the other lcd files.

If this patch is accepted (or if there is interest), I can try to extend this concept to it to the menu system as well, i.e. to display the current menu.
(application/octet-stream)    list_titles.patch (14.8 KiB)
This task depends upon

Closed by  Dan Everton (safetydan)
Wednesday, 16 August 2006, 06:22 GMT+1
Reason for closing:  Out of Date
Additional comments about closing:  I\'m sorry that we missed this patch when http://www.rockbox.org/tracker/task/5795 got comitted. I\'ll close it now since it is out of date with the functionality in CVS.
Comment by Ben Keroack (bk) - Tuesday, 07 March 2006, 20:33 GMT+1
Works well! I think it's a great idea to implement this for menus as well (they both use the list widget, so it shouldn't be too hard to do).

Is it possible to highlight the title somehow? Display it in inverse or underline?

Shouldn't the root dir have a title too? "/" ? If menus have titles this will be less of an issue.
Comment by Nicolas Pennequin (nicolas_p) - Thursday, 16 March 2006, 18:22 GMT+1
I made a version of this patch which will apply and compile cleanly against paprica's scroll margins patch (which can be found here : http://www.rockbox.org/tracker/task/2994 )
Use -p0 to apply
   list_titles_scrollmargins.pat... (16.3 KiB)
Comment by Mark Arigo (lowlight) - Tuesday, 21 March 2006, 22:33 GMT+1
UPDATE: 2006-03-21
Synced to current cvs.
(application/octet-stream)    list_titles.patch (14.8 KiB)
Comment by Nicolas Pennequin (nicolas_p) - Wednesday, 22 March 2006, 14:04 GMT+1
Your sync was broken by a commit which changed english.lang.
I resynched it with the current CVS (2006.03.22), and made a version which will apply cleanly against the scroll margins patch

BTW: I love your patch :) I hope it'll get included in CVS soon...
   list_titles.patch (16.3 KiB)
   list_titles_scrollmargins.pat... (16.3 KiB)
Comment by Martin Guillon (carmenm) - Friday, 24 March 2006, 09:58 GMT+1
Would it be possible not to display it on the remote because we already dont have a lot of lines displayed, so one less is quite annoying ;)
Comment by Nicolas Pennequin (nicolas_p) - Tuesday, 04 April 2006, 18:22 GMT+1
upadated for current CVS
Comment by Nicolas Pennequin (nicolas_p) - Tuesday, 04 April 2006, 23:18 GMT+1
fixed a small mistake in the previous patch and added a version which will apply and compile cleanly against the scroll margins patch.
(application/octet-stream)    list_titles.patch (16.4 KiB)
(application/octet-stream)    list_titles_scrollmargins.pat... (16.4 KiB)
Comment by saa[b_r]ider (Rayyan Fairaq) - Friday, 23 June 2006, 18:58 GMT+1
I tried to patch using the list_titles_scrollmargins.patch posted on April 4, but it fails to patch properly with June 23's CVS.

Can we get an update?

Loading...