Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category User Interface → Language
  • Assigned To
    bagder
  • Operating System Iriver H300 series
  • Severity Low
  • Priority High
  • Reported Version
  • Due in Version Version 3.0
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by veg - 2006-03-13
Last edited by christi-s - 2006-03-19

FS#4828 - Incorrect button definitions for rebooting after upgrade

Upgraded rockbox to the latest daily build (ie replaced rockbox.iriver and the .rockbox/ directory while the H340 was mounted via USB). After unmounting the H340 from the PC's filesystem, the choice is shown on the display to either:

(a) press Play to reboot immediately into the new rockbox version or;
(b) press any other key to leave the reboot until later.

In fact, the opposite occurs: Play does not cause an immediate reboot but any other key does.

Closed by  bagder
2006-04-10 09:11
Reason for closing:  Fixed
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

This was no actual bug and I don\'t see any language strings that mentions \"play\" or similar for this.

Are you sure it's *any* other key, or just NAVI?
NAVI is "Play" for that screen's purposes.

veg commented on 2006-03-14 09:14

Yeah, looks like I remembered it wrong. After trying this again I notice the message is in fact:


Boot changed
Reboot now?

PLAY = Yes
Any Other = No


And YES, "NAVI" gives a reboot, and any other key does not. So NAVI is defined as PLAY, like you said.

Is there a way to change the message to say NAVI instead of PLAY? Or is that a horrible task which can't be done easily just to accommodate the H3x0 port?

Well, specifically the H300 port (and even the H100) aren't released yet, so details like this are very minor. The idea is that they're eventually migrating to a new language system, which will let them have target-specific strings. Until they do, if I understand the screen has to say the same thing on all targets. So basically, coming up with a way around it temporarily would be a hackish thing anyway, and it'd be something that would just get removed later when the new language system is in. Since it's not officially "released" yet, there's no real cause to clean this up as a temporary measure.

At least, that's my understanding of the whole thing.

veg commented on 2006-03-14 15:13

Ah, that would explain it. I probably wouldn't have reported it if I'd bothered to try and understand it first…

Also present for the bookmark on stop and bookmark delete dialogs.

Project Manager

The bad strings are being fixed in the langv2 system, which is now targeted for mayday.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing