Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category User Interface → Themes
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by nicolas_p - 2006-03-17
Last edited by nicolas_p - 2006-03-19

FS#4843 - Bugfix: ID3 info screen (from WPS) backdrop & statusbar

This fixes a very annoying bug : the WPS backdrop was displayed in the ID3 info screen when it was called directly from the WPS with the shortcut (PLAY + A-B on H300).

   browse_id3_backdrop.patch (0.7 KiB)
Closed by  linusnielsen
2006-03-21 11:32
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Thanks!

nicolas_p commented on 2006-03-19 19:35

new patch to fix another bug, related to the satusbar in the ID3 info screen. If the WPS disabled the statusbar when it was enabled in the global settings, the ID3 info screen would be displayed with an incorrect y margin.

   id3_info.patch (1.4 KiB)
nicolas_p commented on 2006-03-19 20:02

Oops, the patch above set an incorrect y margin for WPSs without the statusbar. It's fixed now

   id3_info_v2.patch (1.9 KiB)
Project Manager
linusnielsen commented on 2006-03-20 08:44

In Rockbox, the general policy is that the caller is responsible for restoring the margins after calling a screen or menu function. Therefore I suggest this patch instead.

   id3_info_v3.patch (1.7 KiB)
nicolas_p commented on 2006-03-21 10:27

Thanks for having a look at it, Linus :)
Your patch works fine for me, i suggest committing it to CVS.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing