This is the bug/patch tracker for Rockbox. Click here for more information.
Quick links: Bugs · Patches · Rockbox frontpage
FS#4864 - text editor for rockbox
Attached to Project:
Rockbox
Opened by Jonathan Gordon (jdgordon) - Monday, 20 March 2006, 14:09 GMT+2
Opened by Jonathan Gordon (jdgordon) - Monday, 20 March 2006, 14:09 GMT+2
|
Detailsjust a very simple text editor for rockbox..
ok, so the way this works is its a really simple line based editor.. load the file from the open with menu and it will display the whole file in the list (max line length is 128, and max lines is 1024, so 128kb which should fit nicely in all the targets plugin buffer cept the archos..) press select to goto the keyboard and edit the current line (iriver: NAVI/middle button, ipod: select). press menu to get a list of things u can do (iriver:a-b button, ipod:menu) hopefully all the menu items are easy enough to understand... pressing delete (iriver:rec, ipod:left) will remove the line and put it on the "clipboard" so u can paste it from the menu (use the insert before/after item) and lastly, press exit (iriver: off, ipod:menu+select) to exit, you'll get a menu asking u if u want to save if the file has been changed. the reason why ive only mentioned ipod and iriver keys is coz i dont know whats good on the other targets, so if u have an idea please reply with key combos.. (the delete button is optional, the rest are required). 
text_ed.patch
(19.5 KiB)
gui/list.c | 9 - gui/list.h | 6 plugin.c | 21 ++ plugin.h | 24 ++ plugins/SOURCES | 1 plugins/text_editor.c | 436 +++++++++++++++++++++++++++++++++++++++++++++++++ plugins/viewers.config | 1 7 files changed, 492 insertions(+), 6 deletions(-) |
This task depends upon
There seems to be a bug with 'cut' though (unless it has been fixed in this version - will try when I get home), It seems to fill the whole text buffer with the lines above the cursor. i.e.
line 1
line 2
line 3 <- cursor
line 4
line 5
will become:
line 1
line 2
line 1
line 2
line 1
Also as mentioned in my forum post, I would love to be able to break/join lines of text.
Cheers
Roolku
you can join lines now (use the cat to above menu item), but not split a line.. i cant tihnk of a nice, logical way to do it (ui wise)...
new patch attached
to split a line, go into the menu, choose split line, then u need to remove the end of the line, the removed text then becomes the next line (inserted as a new line.. doesnt overwrite the cureent next line.)
Any chance to have it updated (or even included in cvs)?
Thanks a lot!
$ patch -p0 < text_ed.patch
patching file apps/plugin.c
Hunk #1 FAILED at 411.
1 out of 1 hunk FAILED -- saving rejects to file apps/plugin.c.rej
patching file apps/plugin.h
Hunk #1 FAILED at 479.
1 out of 1 hunk FAILED -- saving rejects to file apps/plugin.h.rej
patching file apps/gui/list.c
patching file apps/gui/list.h
patching file apps/plugins/SOURCES
Hunk #1 FAILED at 16.
1 out of 1 hunk FAILED -- saving rejects to file apps/plugins/SOURCES.rej
patching file apps/plugins/text_editor.c
patching file apps/plugins/viewers.config
Hunk #1 FAILED at 15.
1 out of 1 hunk FAILED -- saving rejects to file apps/plugins/viewers.config.rej
Since you have already gone through the process, would you consider creating a patch for the benefit of others?
Thank you
updated for the latest cvs... except i updated the wrong patch file, so the line splitting isnt in this version (good thing, coz i didnt like how it was being done anyway, ill submit a patch later with a better way if this makes it in before the free).
it needs button definitions for all targets except ipod and iriver, each target needs 3 buttons, select, menu, and quit/cancel....