Rockbox

Tasklist

FS#4928 - button assignment for pitch screen breaks shift key function

Attached to Project: Rockbox
Opened by Robert Kukla (roolku) - Sunday, 26 March 2006, 23:58 GMT
Task Type Bugs
Category User Interface
Status Closed
Assigned To No-one
Operating System Iriver H100 series
Severity High
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

When the pitch screen became a menu item, the key activation also changed (to the worse). It is now triggered by:

case BUTTON_ON | BUTTON_REPEAT:

which means you only get a very short chance to use the shifted functions like id3 display or directory skip before the pitch screen appears. This renderes those functions unusable. Could the function please be re-assigned, for instance to

case BUTTON_ON | BUTTON_OFF:

or (even better) the old way restored, where the pitch screen only appeared when you actually changed the pitch. It saddens me greatly, that these clever functions are replaced by inferior versions. First we lost the "quick" menu (which now has to be turned off expicitly, rather than disappear automatically when you release the mode button) and now that. But I guess that is the price you pay for the support of the new targets. :(

Robert
This task depends upon

Closed by  Zakk Roberts (midkay)
Friday, 21 April 2006, 06:12 GMT
Reason for closing:  Fixed
Additional comments about closing:  Sorry for the wait; this is fixed in CVS. Now the screen only comes up with \"SHIFT\"+Up/Down.
Comment by Zakk Roberts (midkay) - Monday, 27 March 2006, 06:56 GMT
'Twas me who updated the pitch screen functionality. Sorry for the inconvenience - I didn't consider the ID3 viewer, and I wasn't even aware of the Directory skip. :)

I'll fix the screen tomorrow, I think - I'd like to consider the possibilities, but I need to go to bed very soon. Back to the old functionality is the most likely (I can't remember why exactly I changed the button mappings, but I'm not quite sure that it was just for fun, so I need to look into that again).
Comment by Robert Kukla (roolku) - Monday, 27 March 2006, 13:24 GMT
Thanks for looking at it. I think a-b repeat also used the shift key (play).

As for the quick menu screen (hold mode and use up/down/left/right until you let go of mode) - this was broken a while ago (I think by timid when he did the multi screen support). IIRC either amiconn or preglow commented that some clever sequence checking on the button events had to be done, as the mode key can't normally work as a modifier. If you could fix this as well that would be great.

Loading...