Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#4999 - Peakmeter scaling dots does not respect x-offset in peak_meter_draw

Attached to Project: Rockbox
Opened by Matthias Mohr (aka Massa) (mmohr) - Sunday, 02 April 2006, 19:13 GMT+2
Task Type Bugs
Category Themes
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Low
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

when the function peak_meter_draw will be used with the x-offset > 0,
the scaling dots (which are visible between the left and right peakbar)
don't take respect of the given x offset, their offset is always 0.

It's not noticeable in the normal CVS usage (because the function will
currently always be called with an offset of 0)
but it is noticeable e.g. for my peakmeter margins patch ;)
This task depends upon

Closed by  Linus Nielsen Feltzing (linusnielsen)
Monday, 03 April 2006, 10:20 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Thanks!
Comment by Matthias Mohr (aka Massa) (mmohr) - Sunday, 02 April 2006, 19:14 GMT+2
Here is the one line fix for that problem...
(application/octet-stream)    peakmeter_dot_bugfix_20060402.patch (0.7 KiB) 
 apps/recorder/peakmeter.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comment by fabrice dussapt (gaston) - Sunday, 02 April 2006, 20:16 GMT+2
can you make a single patch with this file (i'm not a developer at all, i don't have compiling tools) ?

other question: could the peakmeter bars be vertical instead of horizontal ?

Loading...