Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Infrastructure → Build environment
  • Assigned To No-one
  • Operating System All players
  • Severity High
  • Priority High
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by rasher - 2006-04-03
Last edited by rasher - 2006-05-18

FS#5013 - Fwpatcher fix spurious patching attempts

This patch fixes the problem with fwpatcher that meant it’d attempt to patch all the time. The problem was that the commandline driven interface used WM_USER as signal to start patching. This signal is reserved and will be generated for a lot of different commands. The solution is to use something in the range 0xC000-0xFFFF which is available for applications as signal instead as per http://msdn.microsoft.com/library/default.asp?url=/library/en-us/wceshellui5/html/wce50lrfwmuser.asp

Patch severity set to High because without it, keyboard navigation is completely impossible Priority immediate because I don’t think 3.0 should be allowed to ship with an fwpatcher that is not accessible (that is of course if fwpatcher is to be used for 3.0).

Closed by  rasher
2006-06-20 11:01
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Alright, all\'s fine then. I was just a little curious why the fwpatcher had not been updated to include the fix and thought you might have forgot.

Ooops, read that wrong. The correct range is 0×8000 - 0xBFFF. Fixed patch attached.

Just making some noise, since the distributed fwpatcher in the wiki has not been updated to include this fix.

IMHO, this must be done for 3.0.

Project Manager

Yes, the bootloader must be updated anyway so these fixes will be included, as they are in CVS already.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing