Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#5021 - Recording Histogram

Attached to Project: Rockbox
Opened by Jvo Studer (vinylivo) - Tuesday, 04 April 2006, 13:06 GMT+2
Last edited by Peter D'Hoye (petur) - Wednesday, 03 March 2010, 23:17 GMT+2
Task Type Patches
Category Recording
Status Closed
Assigned To No-one
Player Type Another
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

So here is a separated patch (from the agc_enhance_pack) for recording histogram, battery remain time and disk space.

It shows a graph of peak levels over time. A balance meter shows the actual stereo image position. The battery remain time and remaining disk space are shown in graphic and numeric values too.
Use -p1 for patching.
(application/octet-stream)    rec_histogram_1.patch (23.8 KiB) 
 lang/deutsch.lang    |   30 ++++
 lang/english.lang    |   30 ++++
 recorder/peakmeter.c |   23 +++
 recorder/peakmeter.h |    1 
 recorder/recording.c |  372 ++++++++++++++++++++++++++++++++++++++++++++++++++-
 settings.c           |    7 
 settings.h           |    5 
 sound_menu.c         |   19 ++
 8 files changed, 482 insertions(+), 5 deletions(-)

This task depends upon

Closed by  Peter D'Hoye (petur)
Wednesday, 03 March 2010, 23:17 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  histogram accepted, balance, disk and battery parts not taken
Comment by Jvo Studer (vinylivo) - Sunday, 09 April 2006, 19:59 GMT+2
updated for new language format and added coulour support for histogramm.

see AGC patch http://www.rockbox.org/tracker/task/4748 for a version with AGC and Histogram feature because it's not so easy to apply both patches seperate.

this patch was done to daily-2006-04-08 and u need -p1 option for patching.
(application/octet-stream)    rec_histogram_2.patch (29.2 KiB) 
 lang/deutsch.lang    |   70 +++++++
 lang/english.lang    |   70 +++++++
 recorder/peakmeter.c |   23 ++
 recorder/peakmeter.h |    1 
 recorder/recording.c |  460 ++++++++++++++++++++++++++++++++++++++++++++++++++-
 settings.c           |    7 
 settings.h           |    5 
 sound_menu.c         |   19 ++
 status.c             |   14 +
 9 files changed, 665 insertions(+), 4 deletions(-)

Comment by Paul van der Heu (paulheu) - Sunday, 18 June 2006, 14:00 GMT+2
Anyone heard anything from vinylIvo recently? I'd like to see and update to the histogram patch to go with the current AGC build.. I kinda miss the pretty pictures..
Comment by Paul van der Heu (paulheu) - Tuesday, 22 August 2006, 17:05 GMT+2
I synced the histogram patch against current CVS (060822). As far as I can see it works fine..
   histogram_PH.diff (25.5 KiB) 
 lang/deutsch.lang    |   70 ++++++++
 lang/english.lang    |   70 ++++++++
 recorder/peakmeter.c |    6 
 recorder/recording.c |  411 ++++++++++++++++++++++++++++++++++++++++++++++++++-
 settings.c           |    7 
 settings.h           |    5 
 sound_menu.c         |   20 ++
 7 files changed, 585 insertions(+), 4 deletions(-)

Comment by Paul van der Heu (paulheu) - Tuesday, 22 August 2006, 20:17 GMT+2
Using the patch together with the Peakmeter margin and heights patch (http://www.rockbox.org/tracker/task/4871) does not work.. so some works needs to be done there..
Comment by Martin Scarratt (mmmm-) - Wednesday, 23 August 2006, 12:41 GMT+2
Just because one patch isn't compatible with another doesn't mean that work needs to be done.
Work only needs doing if either patch isn't compatible with CVS.
If one of them got committed, then work would need to be done on the other to make them compatible.
Comment by Jonas Häggqvist (rasher) - Wednesday, 23 August 2006, 13:31 GMT+2
In fact, patches should not be adapted to work with other patches, as this makes them harder to test and incorporate into CVS. As Martin said, the only thing that matters is that the patch applies against CVS.
Comment by Paul van der Heu (paulheu) - Wednesday, 23 August 2006, 13:46 GMT+2
I know and understand, it was 'just' a remark..;) As far as I can see the histogram patch I synced works fine against current CVS..

so there! B)
Comment by Peter D'Hoye (petur) - Friday, 03 August 2007, 22:53 GMT+2
*marker* part of REP
Comment by Sanggon, Lee (isanggon) - Thursday, 24 July 2008, 04:11 GMT+2
re-synced incompletely. Almost successful, but histogram printed wrong position. My lack of understanding this patch, I cound not completed this patch. I attach patch files here. Is any one can complete this, please help. I think there remains small, but big step.

I didn't worked saparetely with contdown patch. Attached patch is histogram patch + countdown patch.
When apply these patch, rec_button patch first. rec_button was done by kugel, but you should fix for hxxx series. you can easily fix keymap file, compare with attached keymap file.

rec button patch is here.
http://www.rockbox.org/tracker/task/5555#comment8661
   _rep_except_rec-button_patch_080724.diff (308 KiB) 
 action.h                   |    1 
 gui/statusbar.c            |  118 +
 gui/statusbar.h            |    9 
 keymaps/keymap-h1x0_h3x0.c |   16 
 keymaps/keymap-ondio.c     |    7 
 keymaps/keymap-x5.c        |    3 
 lang/english.lang          |  218 +++
 menus/recording_menu.c     |  127 +
 recorder/icons.c           |   10 
 recorder/icons.h           |    7 
 recorder/peakmeter.c       |  118 -
 recorder/peakmeter.h       |    2 
 recorder/recording.c       |  859 +++++++++++-
 recorder/recording.c.orig1 | 3034 ++++++++++++++++++++++++++++++++++++++++++++
 recorder/recording.c.orig2 | 3036 +++++++++++++++++++++++++++++++++++++++++++++
 recorder/recording.h       |   17 
 settings.c                 |  300 ++++
 settings.h                 |   17 
 settings_list.c            |   11 
 tree.c                     |    1 
 20 files changed, 7772 insertions(+), 139 deletions(-)

   keymap-h1x0_h3x0.c (56.1 KiB)
Comment by Sanggon, Lee (isanggon) - Thursday, 24 July 2008, 08:23 GMT+2
Now, solved histogram positon problem. This problem was related with statusbar issue.
Remaining works is two.

1. remove last blank line upper of histogram
2. filename printing issue : when goes in recording, filename is missing.
   _rep_except_rec-button_patch_080724_2.diff (311.5 KiB) 
 action.h                   |    1 
 gui/statusbar.c            |  118 +
 gui/statusbar.h            |    9 
 keymaps/keymap-h1x0_h3x0.c |   16 
 keymaps/keymap-ondio.c     |    7 
 keymaps/keymap-x5.c        |    3 
 lang/english.lang          |  218 +++
 menus/recording_menu.c     |  127 +
 recorder/icons.c           |   10 
 recorder/icons.h           |    7 
 recorder/peakmeter.c       |  118 -
 recorder/peakmeter.h       |    2 
 recorder/recording.c       |  953 +++++++++++++-
 recorder/recording.c.orig1 | 3034 ++++++++++++++++++++++++++++++++++++++++++++
 recorder/recording.c.orig2 | 3036 +++++++++++++++++++++++++++++++++++++++++++++
 recorder/recording.h       |   17 
 settings.c                 |  300 ++++
 settings.h                 |   17 
 settings_list.c            |   11 
 tree.c                     |    1 
 20 files changed, 7866 insertions(+), 139 deletions(-)

Comment by Peter D'Hoye (petur) - Sunday, 19 October 2008, 23:14 GMT+2
I'm looking at getting the remainders of the REP. Your updated patch contains two files that do not belong there and I think some other stuff that was already committed. I'm basing my work on an earlier patch, unless you tell me you fixed some bugs in there...
Comment by Peter D'Hoye (petur) - Friday, 12 February 2010, 00:20 GMT+2
YAY... histogram patch - next generation.
This patch does histogram only, no battery, diskspace or balance

Only tested briefly on h300
   histo_NG_1.patch (20.4 KiB) 
 apps/features.txt                   |    4 
 apps/lang/english.lang              |   35 ++++
 apps/menus/recording_menu.c         |   23 ++-
 apps/recorder/peakmeter.c           |   36 ++--
 apps/recorder/recording.c           |  269 +++++++++++++++++++++++++++++-------
 apps/settings.h                     |    4 
 apps/settings_list.c                |    7 
 firmware/export/config-h300.h       |    1 
 firmware/export/config/iriverh300.h |    2 
 9 files changed, 317 insertions(+), 64 deletions(-)

Comment by Peter D'Hoye (petur) - Saturday, 13 February 2010, 01:22 GMT+2
Also (briefly) tested on h1x0, enabled for h1x0 and a small cosmetic fix
   histo_NG_2.patch (20.5 KiB) 
 apps/features.txt                   |    4 
 apps/lang/english.lang              |   35 ++++
 apps/menus/recording_menu.c         |   23 ++-
 apps/recorder/peakmeter.c           |   36 ++--
 apps/recorder/recording.c           |  271 +++++++++++++++++++++++++++++-------
 apps/settings.h                     |    4 
 apps/settings_list.c                |    7 
 firmware/export/config/iriverh120.h |    2 
 firmware/export/config/iriverh300.h |    2 
 9 files changed, 320 insertions(+), 64 deletions(-)

Comment by Jonathan Gordon (jdgordon) - Saturday, 13 February 2010, 01:37 GMT+2
can you please change it so its drawn like a widget or something our of recording.c? move all its logic out into apps/histogram.c or something? if it uses the peak values does that mean it could be used on the wps also?

please please please just change (at least) the drawing code to just draw the historgram in a given viewport on the screen.
Comment by Peter D'Hoye (petur) - Saturday, 20 February 2010, 00:45 GMT+2
code cleanup
   histo_NG_3.patch (18.5 KiB) 
 apps/features.txt                   |    4 
 apps/lang/english.lang              |   35 +++++
 apps/menus/recording_menu.c         |   23 +++
 apps/recorder/peakmeter.c           |   36 +++--
 apps/recorder/recording.c           |  232 ++++++++++++++++++++++++++++--------
 apps/settings.h                     |    4 
 apps/settings_list.c                |    7 +
 firmware/export/config/iriverh120.h |    2 
 firmware/export/config/iriverh300.h |    2 
 9 files changed, 281 insertions(+), 64 deletions(-)

Comment by Peter D'Hoye (petur) - Tuesday, 02 March 2010, 00:41 GMT+2
code cleanup, RC
   histo_NG_4.patch (19.1 KiB) 
 apps/features.txt                   |    4 
 apps/lang/english.lang              |   35 +++++
 apps/menus/recording_menu.c         |   25 +++
 apps/recorder/peakmeter.c           |   36 +++--
 apps/recorder/recording.c           |  238 ++++++++++++++++++++++++++++--------
 apps/settings.h                     |    4 
 apps/settings_list.c                |    7 +
 firmware/export/config/iriverh120.h |    2 
 firmware/export/config/iriverh300.h |    2 
 9 files changed, 287 insertions(+), 66 deletions(-)

Loading...