Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#5049 - Startup Screen option (feature request FS#5020)

Attached to Project: Rockbox
Opened by Alexander Levin (fml2) - Thursday, 06 April 2006, 14:54 GMT+2
Last edited by Nicolas Pennequin (nicolas_p) - Monday, 11 December 2006, 20:55 GMT+2
Task Type Patches
Category Configuration
Status Closed
Assigned To No-one
Player type All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Here is a patch that adds the 'Startup Screen' option to the playback menu (General Settings -> Playback -> Startup Screen). Possible values are:

- File Browser
- FM Radio (only on devices where it's present)
- Playback (formerly known as 'Resume on Startup')
- Recording Screen (only on devices with recording capability, formerly known as 'Start Rockbox in Recording Screen')
- Last Active Screen

The options 'Resume on Startup' and 'Start Rockbox in Recording Screen' have been removed.

Known issues:

1. The 'Last Active Screen' feature is not implemented yet, it's equivalent to 'File Browser' for now (see file tree.c) -- since I don't know where is the best place to track the active screen.

2. Version of the settings structure is increased, so save your settings before installing this patch.

3. I'm not completely sure whether the 'FM Radio' option is implemented correctly, I used the code for 'Recording Screen' as a template.

So it would do no harm if a developer familiar with Rockbox structure would throw a critical look at it!
(application/octet-stream)    startup_screen.patch (8.3 KiB)
This task depends upon

Closed by  Dave Chapman (linuxstb)
Wednesday, 21 February 2007, 12:19 GMT+2
Reason for closing:  Out of Date
Additional comments about closing:  As mentioned in the last comment, this functionality will be part of the \"root menu\" patch currently in development - FS #6630
Comment by David Brown (ep0ch) - Thursday, 06 April 2006, 20:35 GMT+2
Instead of calling it "Startup Screen" maybe "Startup Behaviour" is more suitable?
Comment by Alexander Levin (fml2) - Friday, 07 April 2006, 08:28 GMT+2
Yes, 'Startup Behaviour' would be more suitable. Other location in the menu would also be more suitable, I only can't figure out what exactly it should be. 'Playback' is it definitely not.
Comment by Davide (Davide-NYC) - Thursday, 01 June 2006, 22:02 GMT+2
I have another suggestion. Have a setting that selects the internal microphone as recording input in the recording screen. On an iRiver H1xx (for example) you can select one of three input sources (mic, line, or optical) I assume the last input state is retained when restarting the player. When you're in a rush and just want to get that quick recording switching inputs is a drag. I would be gtreat if you could just turn the player on and then hit record. Two button presses no matter what input was selected last time you exited the record screen.
This would be really helpful for musicians that want to jot down ideas really quickly or for people that like to take voice memos often.
Cheers!
Comment by Alexander Levin (fml2) - Friday, 02 June 2006, 13:35 GMT+2
> Have a setting that selects the internal microphone as recording input in the recording screen

Do you mean another entry in the Startup Screen menu? Or a different setting? I don't like the former and would probably like the latter. I.e. you'd have (probably somewhere in the recording related menu) an option for input source with the values mic, line in, optical, last active. And then, if you go to the recording screen, the selected source is used. But it has nothing to do with this feature request/patch.

But *whether* you go to the recording screen is set via this option (i.e. from this patch).
Comment by Alexander Levin (fml2) - Wednesday, 16 August 2006, 22:02 GMT+2
Updated the patch. Now the radio also activated (testes on iriver H1xx). This is done by calling sleep(2 sec) thus allowing the background thread to initialize the audio subsystem. The last active screen is still not saved.
(application/octet-stream)    startup-behaviour.patch (11.7 KiB)
Comment by Alexander Levin (fml2) - Thursday, 17 August 2006, 23:41 GMT+2
Updated the patch.

- Lang file keeps the old lines for resume on start up and recording screen on startup (not needed anymore) since I don't want to bump the lang file version
- Last active screen is now tracked

One problem remains: since stop is triggered on button press (not on button release), the shut down process is never started from the WPS screen. I.e. WPS (and radio, and recording) can't be the last active screen before shut down. So that option ('last active' it is) will always activate file browser after start up.
(application/octet-stream)    startup-behaviour2.patch (15 KiB)
Comment by Alexander Levin (fml2) - Friday, 18 August 2006, 22:13 GMT+2
Updated the patch once again. Replaced not used strings in english.lang with "" and placed DEPRECATED as description.
(application/octet-stream)    startup-behaviour3.patch (15.8 KiB)
Comment by Alexander Levin (fml2) - Sunday, 20 August 2006, 14:49 GMT+2
Changed button mapping for radio screen for iriver H1xx: radio mode is left on stop release, not on stop push. Now the option 'last active screen' works correctly for WPS and for the radio screen. Which stisfies me as I don't use recording feature. BTW: button mapping in the radio and recording screens are not implemented using the new action code. That's no good!
(application/octet-stream)    startup-behaviour4.patch (16.1 KiB)
Comment by Alexander Levin (fml2) - Friday, 01 September 2006, 21:19 GMT+2
Updated the patch. No functional changes.
(application/octet-stream)    startup-behaviour5.patch (16.3 KiB)
Comment by Alexander Levin (fml2) - Sunday, 03 September 2006, 10:22 GMT+2
I give up! :-) The patch from Sep 01 again has conflicts. RB changes at such a high pace that I can't keep up with it. When the devs decide that this feature is worth including it into CVS, I (or someone else) will update the patch. Now it's (almost) a waste of time.
Comment by Nicolas Pennequin (nicolas_p) - Wednesday, 21 February 2007, 02:40 GMT+2
The root menu ( FS#6630 ) will allow this.

Loading...