Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#5056 - reworked viewer plugin

Attached to Project: Rockbox
Opened by Jonathan Gordon (jdgordon) - Friday, 07 April 2006, 04:55 GMT+2
Task Type Patches
Category Plugins
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

i have reworked a fair bit of the viewer plugin to make it a bit nicer...
the off button now quits again, and each target now has a dedicated menu button. all the plugin settings are edited from the menu so no need to remeber which key does which anymore..

also, ive added a new setting to choose if u want to scroll by page or line (up/down only atm) and you can save settings as the default settings, not only per-file settings now.

everything works, except the scrollbar setting, and im not sure why.. so someone else can see if they an figure that out.
(application/octet-stream)    viewer.diff (18 KiB) 
 viewer.c |  396 +++++++++++++++++++++++++++++----------------------------------
 1 file changed, 184 insertions(+), 212 deletions(-)

This task depends upon

Closed by  Zakk Roberts (midkay)
Monday, 01 May 2006, 08:13 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Added in CVS. Thanks. :)
Comment by Anton Romanov (theli) - Monday, 17 April 2006, 15:56 GMT+2
bug: enter setting 'Scrollbar Mode' -> don't change -> press menu -> it displays 'canceled' but enter again -> setting reversed
pushing 'select' has the same effect ... otherwise scrollbar setting really works

except that when scrollbar is disabled there is still space for it in the left

otherwise this patch greatly enhances viewer (cause using different hotkeys is REALLY horrible (for example - on ipod pressing select+prev+next is way hard)

merging this with 'half-screen width' bugfix from
http://www.rockbox.org/tracker/task/4873
would make viewer way better and comfortable to use

(well, codepage selection would be nice too... but not critical)
Comment by Jonathan Gordon (jdgordon) - Monday, 17 April 2006, 16:20 GMT+2
ok, ive removed some code which im not 100% sure what it does, but it fixed the scroll bar problem :p it apears to be working...
merging that other patch will be fun... ill give it a go..
(application/octet-stream)    viewer.diff (18.2 KiB) 
 viewer.c |  391 +++++++++++++++++++++++++++++----------------------------------
 1 file changed, 181 insertions(+), 210 deletions(-)

Comment by Jonathan Gordon (jdgordon) - Monday, 17 April 2006, 17:10 GMT+2
.. well that was simple... the other patch merged perfectly (well almost) with my changes...
so here we have both patches together (with encoding selection, dunno if it works tho)..
only problem is that the line mode and scrollbar options crashes the sim but works fine on the target (h300).. so if some1 wants to figure that out? (i dont have gdb setup)
(application/octet-stream)    viewer_encoding.diff (32.2 KiB) 
 viewer.c |  623 ++++++++++++++++++++++++++++++++++-----------------------------
 1 file changed, 341 insertions(+), 282 deletions(-)

Comment by Anton Romanov (theli) - Monday, 17 April 2006, 17:33 GMT+2
well, for me even clean cvs viewer crashes sim ... but works fine on player (ipodmini2g)
Comment by Anton Romanov (theli) - Monday, 17 April 2006, 17:38 GMT+2
hm ... but with this patch i can't crash it on my target's sim as well as on player :)
Comment by Anton Romanov (theli) - Monday, 17 April 2006, 17:42 GMT+2
well... configuring options would be cool feature too :P
cause for example, on ipod, scrolling with wheel is not to convinient ... as for me i would disable wheel scroll ... have select+menu for menu, (or just select) , and play - scroll down, menu - scroll up

well, maybe that is just the matter of taste so .. ability to modify control keys would be cool to :)
Comment by Anton Romanov (theli) - Monday, 17 April 2006, 19:53 GMT+2
hm ... another bug?
1. viewer doesn't saves file position on player but does on simulator :|
2. i have always had for unknown reason a symbol 'J' in places where there are end of lines in file ...
this happened both with sim and player... now with the sim it is fixed but i still have this on player ...

it looks like this
http://theli.ho.com.ua/book.png
with vanilla viewer.c
Comment by Anton Romanov (theli) - Thursday, 20 April 2006, 15:57 GMT+2
well, those bug mentioned before looks like ipod-specific ...
http://www.rockbox.org/tracker/task/4729
and doesn't go here

Loading...