Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#5179 - Playlist Catalog

Attached to Project: Rockbox
Opened by Shachar (Lamed) - Wednesday, 19 April 2006, 15:06 GMT+2
Task Type Patches
Category Playlists
Status Closed
Assigned To No-one
Player type All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This is the playlist catalog by Sebastian Henriksen that was introduced somewhere around h1x0 forum and sourceforge, updated to 19.4.06 cvs.


to install:
copy playlist_catalog.c, playlist_catalog.h to your rockbox/apps folder, and patch the playlist_catalog_new file
(using $ patch -p0 > playlist_catalog_new)
(application/octet-stream)    playlist_catalog-new (8.6 KiB)
(application/octet-stream)    playlist_catalog.c (18.1 KiB)
(application/octet-stream)    playlist_catalog.h (2.5 KiB)
This task depends upon

Closed by  Linus Nielsen Feltzing (linusnielsen)
Tuesday, 18 July 2006, 15:56 GMT+2
Reason for closing:  Accepted
Comment by Shachar (Lamed) - Wednesday, 19 April 2006, 16:14 GMT+2
don't use playlist_catalog-new, it's older. (some patching problems)
(application/octet-stream)    playlist_catalog_4.19.06 (8.6 KiB)
Comment by Mike (Falco98) - Wednesday, 10 May 2006, 19:54 GMT+2
i'm confused.. where can i find out exactly what "playlist catalog" *does*?
Comment by Hardeep Sidhu (hardeeps) - Saturday, 13 May 2006, 22:08 GMT+2
I've done a massive rewrite of this patch to fix most of the lingering issues. Changes include:

1. All playlists must now be in one directory. The default directory is /Playlists but this can be changed by creating the file /.rockbox/playlist_catalog_config and adding the line "dir:/my/playlist/path name". All related add to/remove from playlist catalog options have been removed from the gui.

2. Only the most recently modified playlist is remembered and placed at the top of the list. All other playlists are ordered based on the file tree configuration.

3. Removed most of the duplicated code when inserting directories (required modifications to playlist code as well)

4. All onplay functionality is available when "View playlists" is selected.

One change I didn't make was to move to the gui_synclist_* functions when browsing the playlist. This is mainly because the menu code is working reasonably well. However, this may still be changed. Aside from this, there's still a little cleanup and documentation that needs to be done. Once that's complete, this patch should be ready for inclusion into the builds (post 3.0 of course).

NOTE: When applying the patch you no longer need to manually copy the playlist_catalag.* files, they are now a part of the patch itself.
(application/octet-stream)    playlist_catalog.diff (27.1 KiB)
Comment by Hardeep Sidhu (hardeeps) - Sunday, 14 May 2006, 00:15 GMT+2
Patch updated to use gui_synclist_* to properly handle the context menu when viewing catalog. Now, if you select a playlist while viewing, it'll begin playback (shuffling if enabled). Context menu (to delete, rename, view, etc.) is now accessed using same keys as dir browser.
(application/octet-stream)    playlist_catalog_2.diff (29.8 KiB)
Comment by Hardeep Sidhu (hardeeps) - Monday, 15 May 2006, 23:09 GMT+2
Patch updated to latest CVS. Also cleaned up / documented the code. NOTE: The playlist catalog config file has been renamed to /.rockbox/playlist_catalog.config to keep it consistent with the other config files.
(application/octet-stream)    playlist_catalog_3.diff (32.6 KiB)
Comment by Hardeep Sidhu (hardeeps) - Tuesday, 30 May 2006, 18:04 GMT+2
Patch updated to latest CVS. Also renamed "View" to "View catalog" in WPS context menu as requested.
(application/octet-stream)    playlist_catalog_4.diff (31.7 KiB)
Comment by saa[b_r]ider (Rayyan Fairaq) - Friday, 23 June 2006, 19:22 GMT+2
Hi. I tried to apply playlist_catalog_4.diff to June 23's CVS but it wouldn't complete. Can we have an update?
Comment by Hardeep Sidhu (hardeeps) - Saturday, 24 June 2006, 18:31 GMT+2
It patches fine for me with latest CVS. I suspect it's a problem with your source tree.
Comment by Simon Menzel (Rincewind) - Friday, 14 July 2006, 16:01 GMT+2
I have a problem with this patch now, too.
I get the following compiler error:

playlist_catalog.c:236: error: too few arguments to function 'gui_synclist_init'

I don't know which cvs update caused this, because I stopped using patches for a while.
Comment by Simon Menzel (Rincewind) - Friday, 14 July 2006, 16:35 GMT+2
I managed to work around the error.
In playlist_catalog.c at line 236 replace
gui_synclist_init(&playlist_lists, playlist_callback_name, playlists);
with
gui_synclist_init(&playlist_lists, playlist_callback_name, playlists, false, 1);

I don't want to put up a patch myself, because I'm not sure if the fix is right (it's working for me, but not tested with remote etc.)

PS: I have a feature request for the playlist catalog:
Use the Dircache. Right now the disk has to spin up everytime I want to use the catalog.
Also there is a little grammar mistake. If no playlists exist then there is a splash message "playlists doesn't exist". It should say "don't"
Comment by Hardeep Sidhu (hardeeps) - Friday, 14 July 2006, 18:00 GMT+2
Updated patch to latest CVS.

The feature does use the dircache to retrieve filenames. There will be a disk access the first time it's called to determine the playlist catalog directory but there shouldn't be any afterwards (assuming the directory exists). In regards to the grammar error, that message is referring to the directory you specified in your playlist_catalog.config file (default is /Playlists). I'm guessing the error you saw was actually: "/Playlists doesn't exist".
(application/octet-stream)    playlist_catalog_5.diff (31.7 KiB)

Loading...