- Status Closed
- Percent Complete
- Task Type Patches
- Category Games
- Assigned To No-one
- Operating System All players
- Severity Very Low
- Priority Very Low
- Reported Version
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
FS#5356 - Sokoban patch: Unified duplicate code into a function
A sokoban patch: I unified four virtually identical blocks of code into a function. This has no effect on functionality, but it might make the code easier to maintain.
(Aside: Are patches like this too trivial to submit? I’m new to the project, so please tell me if they are
Closed by bluebrother
2007-02-13 10:13
Reason for closing: Out of Date
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
2007-02-13 10:13
Reason for closing: Out of Date
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
closed upon request as superseded by
FS#6625
according to reporter.
Loading...
Available keyboard shortcuts
- Alt + ⇧ Shift + l Login Dialog / Logout
- Alt + ⇧ Shift + a Add new task
- Alt + ⇧ Shift + m My searches
- Alt + ⇧ Shift + t focus taskid search
Tasklist
- o open selected task
- j move cursor down
- k move cursor up
Task Details
- n Next task
- p Previous task
- Alt + ⇧ Shift + e ↵ Enter Edit this task
- Alt + ⇧ Shift + w watch task
- Alt + ⇧ Shift + y Close Task
Task Editing
- Alt + ⇧ Shift + s save task
…in fact, after the above change, I can remove some unnecessary local variables. This new patch replaces the earlier one.
Argh! My first patch was dodgy (iPods don’t define one of button defs I used). Here’s yet another patch. Sorry!
This task can now be closed. It is superseded by
FS#6625was hasbeen committed.