This is the bug/patch tracker for Rockbox. Click here for more information.
Quick links: Bugs · Patches · Rockbox frontpage
FS#5602 - Allow wav files with 'fmt ' chunk past MAX_PATH bytes
|
DetailsCurrently Rockbox is unable to play WAV files that have a large header before the 'fmt ' chunk. For example, wav files created with Pro-Tools or Wavelab will not work. This is due to a problem in both the wav codec and the wav metadata parser. The wav codec assumes the 'fmt ' chunk is within the first 1024 bytes of the file and even worse, the metadata parser assumes it's within the first MAX_PATH bytes.
This patch allows for the 'fmt ' chunk to be located at any arbitrary location in the file as long as it still appears before the 'data' chunk. This fixes the problem and sample file from the forums: http://forums.rockbox.org/index.php?topic=3381.0 
wav.patch
(6.3 KiB)
apps/metadata.c | 68 +++++++++++++++++++++++++++++++----------------------- apps/codecs/wav.c | 47 ++++++++++++++++++++++--------------- 2 files changed, 68 insertions(+), 47 deletions(-) |
This task depends upon
Comment by Adam Boot (rotator) -
Tuesday, 27 June 2006, 04:59 GMT+2
I'd appreciate it if someone could look over and test this patch to make sure I didn't break anything. If everything looks ok, would it be alright if I committed this since it's a bugfix that impacts 3.0 targets?