Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#5607 - Speex codec interface (&library)

Attached to Project: Rockbox
Opened by Frederik (freqmod) - Tuesday, 27 June 2006, 19:26 GMT+2
Task Type Patches
Category Codecs
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Tested on iPod video with gcc 3.4.3. (GCC 4.0.3 on iPod gives me the sound of silence).
Gcc 4.0.3 works with sound using the simulator on x86_64 (with the same target).
Logf gives some messages, and printf is used too (if SIMULATOR is defined).
Based on speex SVN from week 21.06.2006.
Uses arm4 assembly if ARM_CPU is defined.

Seeking and changing tracks work.
Seeks in the start backwards so you loose a bit of playback.
Vorbis metadata tags are parsed.

Includes a little workaround for a segmentation fault when using crossfade.

Decodes NB&WB speex files (up to 16kHz) realtime on iPod video.

Patch against rockbox CVS as of 25.06.2006.
   speex.v003.patch.zip (129.8 KiB)
This task depends upon

Closed by  Dan Everton (safetydan)
Friday, 09 February 2007, 11:22 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Checked in to SVN as revision 12241. Cheers.
Comment by Frederik (freqmod) - Tuesday, 27 June 2006, 21:48 GMT+2
Fix for skipping in the beginning of playback (caused by reallocation in libogg)

I have tried, and would very much like to see it ported to Tremor/framing, but the memory management code caused segmentation faults when libogg was working so I was not able to figure it out.

Pach must depends on speex.v003.patch
   speex.v003.1.patch (5.3 KiB) 
 rockboxD/apps/codecs/libogg/framing.c |   16 ++++++++--
 rockboxD/apps/codecs/libogg/ogg/ogg.h |    1 
 rockboxD/apps/codecs/speex.c          |   51 ++++++++++++++++++++++------------
 3 files changed, 48 insertions(+), 20 deletions(-)

Comment by Frederik (freqmod) - Tuesday, 27 June 2006, 21:51 GMT+2
You'll have to remove all (2) printf's in apps/codecs/libogg/framing.c to make it compile on non simulated targets.
Comment by Paul Louden (darkkone) - Wednesday, 28 June 2006, 07:50 GMT+2
It's unlikely to get included (in my opinion) unless you resolve the GCC 4 things, since that's what we use for our iPod builds.
Is there any clue to what's causing it, or is it more an issue of GCC being crazy?
Comment by Jari Lammi (solarflare) - Monday, 10 July 2006, 22:34 GMT+2
Any change to get this patch available as an already compiled experimental build for the iPod mini 2nd gen? I have the gcc version 4.0.0 (Apple Computer, Inc. build 5026). It would be interesting to see how the Dual 80 MHz ARM 7TDMI processors inside perform with Speex if at all.
Comment by Frederik (freqmod) - Wednesday, 12 July 2006, 13:44 GMT+2
Removed (in a way) the silence for (stereo) using gcc 4 on ipod by editing apps/codecs/libspeex/math_approx.c:~106: change spx_sqrtf to be like:
float spx_sqrtf(float arg)
{
if(arg==1.0) return 1.0;
return spx_sqrt(arg); // <---------- this is the line to be added
#if 0
.........
#endif
}
Comment by Dave Chapman (linuxstb) - Thursday, 20 July 2006, 10:40 GMT+2
This patch no longer applies to CVS (probably due to the SID codec being added). Would you be able to update it, preferably as a single patch against CVS?
Comment by Frederik (freqmod) - Friday, 21 July 2006, 18:43 GMT+2
New patch applies against current CVS (as of 2006.07.21 ~18.00 CET). Includes a better (but not very good) sterio square root function, please use mono speex files if possible. Seeking is not improved and it is somewhat flaky, especially in short (about 1 min) files.
   speex.v004.patch.zip (149.2 KiB)
Comment by Frederik (freqmod) - Friday, 21 July 2006, 20:10 GMT+2
Patch (to apply to speex.v004.patch.zip) to get better stereo sound
   math_approx.patch (3.6 KiB) 
 rockbox/apps/codecs/libspeex/math_approx.c |   85 ++++++++++++++++++-----------
 1 file changed, 55 insertions(+), 30 deletions(-)

Comment by Frederik (freqmod) - Saturday, 22 July 2006, 18:43 GMT+2
Fixes speed (& incorperates sterio imporvement). Now speex files encoded with speexenc --vbr --agc --comp 9 --quality 5 (and source files 32kHz mono) decodes nearly realtime (with pich 90% on ipod), which means that they are listenable on a happy day :)

Patch is against speex.v004 patched sources
   speex.v004.1.patch (23 KiB) 
 rockbox/apps/codecs/libspeex/cb_search.c   |  426 -----------------------------
 rockbox/apps/codecs/libspeex/fixed_arm4.h  |    2 
 rockbox/apps/codecs/libspeex/lsp.c         |   77 -----
 rockbox/apps/codecs/libspeex/ltp_arm4.h    |    1 
 rockbox/apps/codecs/libspeex/ltp.c         |    2 
 rockbox/apps/codecs/libspeex/math_approx.c |   85 +++--
 rockbox/apps/codecs/libspeex/sb_celp.c     |   15 -
 rockbox/apps/codecs/libspeex/vq.c          |    2 
 8 files changed, 75 insertions(+), 535 deletions(-)

Comment by Frederik (freqmod) - Thursday, 03 August 2006, 13:31 GMT+2
v005: 32kHz UWB decodes 100% on ipod (gcc4) (with no peak meaters), skips if menues are used.
16kHz WB decodes realtime on ipod (gcc4) with boost half the time.
Crossfade works without workaround.
speex.c confirms to rockbox text format guidelines.

Patch against cvs 2006.8.3.
   speex.v005.patch.zip (120.2 KiB)
Comment by Frederik (freqmod) - Friday, 04 August 2006, 15:22 GMT+2
Not tested on big endian processors, use update be_int & le_int to use #if*def ROCKBOX_BIG_ENDIAN to have a chance.
Comment by Frederik (freqmod) - Wednesday, 30 August 2006, 21:52 GMT+2
Wont work with cvs due changes in id3.c and playback.c
Comment by Frederik (freqmod) - Monday, 25 September 2006, 20:06 GMT+2
Sync with Speex SVN & rockbox CVS, updated to compile without errors with gcc 4.0. (UWB, gets a little slower (just not realtime on iPod)).
   speex.006.diff.zip (177 KiB)
Comment by Frederik (freqmod) - Monday, 25 September 2006, 20:40 GMT+2
in apps/codecs/libspeex/vq.c change:
#elif defined(SHORTCUTS) && (defined(ARM4_ASM) || defined(ARM5E_ASM))
to
#elif (defined(ARM4_ASM) || defined(ARM5E_ASM))
to make uwb work realtime
Comment by Frederik (freqmod) - Wednesday, 18 October 2006, 23:05 GMT+2
Fixed assembly and synced to cvs.
   speex.007.diff.zip (176.8 KiB)
Comment by Frederik (freqmod) - Sunday, 29 October 2006, 01:42 GMT+2
should be better makefiles
   speex.008.diff.zip (178.6 KiB)
Comment by Thom Johansen (preglow) - Monday, 30 October 2006, 18:40 GMT+2
This last patch is broken quite severely, could you please upload one that adds Speex support, not removes it? :)
Comment by Frederik (freqmod) - Tuesday, 07 November 2006, 10:04 GMT+2
I quite agree. I didn't see this before now, but now i am uploading a new synced (afaik working patch)
   speex.009.diff.zip (177.5 KiB)
Comment by Adam (voltagex) - Tuesday, 16 January 2007, 08:04 GMT+2
Any chance of a new working version?
Comment by Frederik (freqmod) - Saturday, 27 January 2007, 19:54 GMT+2
This should work (tested on iPod, but it may be some faults in the diffing).
use 'patch -p0 < patch (unzipped)' to apply
   speex-0.0.010.diff.zip (184.8 KiB)

Loading...